Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Side by Side Diff: src/compiler/simplified-lowering.cc

Issue 2637363002: [turbofan] Unify Smi checking for Check(Internalized)String. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/effect-control-linearizer.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/simplified-lowering.h" 5 #include "src/compiler/simplified-lowering.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "src/address-map.h" 9 #include "src/address-map.h"
10 #include "src/base/bits.h" 10 #include "src/base/bits.h"
(...skipping 2264 matching lines...) Expand 10 before | Expand all | Expand 10 after
2275 ProcessRemainingInputs(node, 1); 2275 ProcessRemainingInputs(node, 1);
2276 SetOutput(node, MachineRepresentation::kNone); 2276 SetOutput(node, MachineRepresentation::kNone);
2277 return; 2277 return;
2278 } 2278 }
2279 case IrOpcode::kCheckInternalizedString: { 2279 case IrOpcode::kCheckInternalizedString: {
2280 if (InputIs(node, Type::InternalizedString())) { 2280 if (InputIs(node, Type::InternalizedString())) {
2281 VisitUnop(node, UseInfo::AnyTagged(), 2281 VisitUnop(node, UseInfo::AnyTagged(),
2282 MachineRepresentation::kTaggedPointer); 2282 MachineRepresentation::kTaggedPointer);
2283 if (lower()) DeferReplacement(node, node->InputAt(0)); 2283 if (lower()) DeferReplacement(node, node->InputAt(0));
2284 } else { 2284 } else {
2285 VisitUnop(node, UseInfo::AnyTagged(), 2285 VisitUnop(node, UseInfo::CheckedHeapObjectAsTaggedPointer(),
2286 MachineRepresentation::kTaggedPointer); 2286 MachineRepresentation::kTaggedPointer);
2287 } 2287 }
2288 return; 2288 return;
2289 } 2289 }
2290 case IrOpcode::kCheckNumber: { 2290 case IrOpcode::kCheckNumber: {
2291 if (InputIs(node, Type::Number())) { 2291 if (InputIs(node, Type::Number())) {
2292 if (truncation.IsUsedAsWord32()) { 2292 if (truncation.IsUsedAsWord32()) {
2293 VisitUnop(node, UseInfo::TruncatingWord32(), 2293 VisitUnop(node, UseInfo::TruncatingWord32(),
2294 MachineRepresentation::kWord32); 2294 MachineRepresentation::kWord32);
2295 } else { 2295 } else {
(...skipping 20 matching lines...) Expand all
2316 } 2316 }
2317 if (lower()) DeferReplacement(node, node->InputAt(0)); 2317 if (lower()) DeferReplacement(node, node->InputAt(0));
2318 return; 2318 return;
2319 } 2319 }
2320 case IrOpcode::kCheckString: { 2320 case IrOpcode::kCheckString: {
2321 if (InputIs(node, Type::String())) { 2321 if (InputIs(node, Type::String())) {
2322 VisitUnop(node, UseInfo::AnyTagged(), 2322 VisitUnop(node, UseInfo::AnyTagged(),
2323 MachineRepresentation::kTaggedPointer); 2323 MachineRepresentation::kTaggedPointer);
2324 if (lower()) DeferReplacement(node, node->InputAt(0)); 2324 if (lower()) DeferReplacement(node, node->InputAt(0));
2325 } else { 2325 } else {
2326 VisitUnop(node, UseInfo::AnyTagged(), 2326 VisitUnop(node, UseInfo::CheckedHeapObjectAsTaggedPointer(),
2327 MachineRepresentation::kTaggedPointer); 2327 MachineRepresentation::kTaggedPointer);
2328 } 2328 }
2329 return; 2329 return;
2330 } 2330 }
2331 2331
2332 case IrOpcode::kAllocate: { 2332 case IrOpcode::kAllocate: {
2333 ProcessInput(node, 0, UseInfo::TruncatingWord32()); 2333 ProcessInput(node, 0, UseInfo::TruncatingWord32());
2334 ProcessRemainingInputs(node, 1); 2334 ProcessRemainingInputs(node, 1);
2335 SetOutput(node, MachineRepresentation::kTaggedPointer); 2335 SetOutput(node, MachineRepresentation::kTaggedPointer);
2336 return; 2336 return;
(...skipping 1155 matching lines...) Expand 10 before | Expand all | Expand 10 after
3492 isolate(), graph()->zone(), callable.descriptor(), 0, flags, 3492 isolate(), graph()->zone(), callable.descriptor(), 0, flags,
3493 Operator::kNoProperties); 3493 Operator::kNoProperties);
3494 to_number_operator_.set(common()->Call(desc)); 3494 to_number_operator_.set(common()->Call(desc));
3495 } 3495 }
3496 return to_number_operator_.get(); 3496 return to_number_operator_.get();
3497 } 3497 }
3498 3498
3499 } // namespace compiler 3499 } // namespace compiler
3500 } // namespace internal 3500 } // namespace internal
3501 } // namespace v8 3501 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/effect-control-linearizer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698