Assert that context creation doesn't throw

Assert that context creation doesn't throw

Instead, it is supposed to just return an empty context if it failed.
Also don't invoke interceptors (we don't for the parts that deserialize
from the snapshot anyways).

BUG=v8:5830
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2636903002
Cr-Commit-Position: refs/heads/master@{#42404}
Committed: https://chromium.googlesource.com/v8/v8/+/0389df514d48c6394f606bf4e5b9b0b0cb134d1b

[jochen (gone - plz use gerrit), 2017-01-16 14:39:19]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 14:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 15:09:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 15:09:44]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-17 09:54:23]

https://codereview.chromium.org/2636903002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2636903002/diff/1/src/api.cc#newcode6211
src/api.cc:6211: ENTER_V8_FOR_NEW_CONTEXT(isolate);
What about stack overflow, which trigger RangeError?

https://codereview.chromium.org/2636903002/diff/1/src/api.cc#newcode6258
src/api.cc:6258: nullptr, Local<Value>(), PropertyHandlerFlags::kNone);
Do we want a canonical no-op interceptor info, created during heap init, and
part of the startup snapshot?

https://codereview.chromium.org/2636903002/diff/1/src/execution.h
File src/execution.h (right):

https://codereview.chromium.org/2636903002/diff/1/src/execution.h#newcode45
src/execution.h:45: // exception is kept pending on the isolate.
Wait... if exception_out is nullptr, TryCall behaves the same as Call?

[jochen (gone - plz use gerrit), 2017-01-17 10:23:58]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[jochen (gone - plz use gerrit), 2017-01-17 10:24:02]

https://codereview.chromium.org/2636903002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/2636903002/diff/1/src/api.cc#newcode6211
src/api.cc:6211: ENTER_V8_FOR_NEW_CONTEXT(isolate);
On 2017/01/17 at 09:54:23, Yang wrote:
> What about stack overflow, which trigger RangeError?

we'd just swallow the exception and return an empty context (as we do for any
other exception)

https://codereview.chromium.org/2636903002/diff/1/src/api.cc#newcode6258
src/api.cc:6258: nullptr, Local<Value>(), PropertyHandlerFlags::kNone);
On 2017/01/17 at 09:54:22, Yang wrote:
> Do we want a canonical no-op interceptor info, created during heap init, and
part of the startup snapshot?

done

https://codereview.chromium.org/2636903002/diff/1/src/execution.h
File src/execution.h (right):

https://codereview.chromium.org/2636903002/diff/1/src/execution.h#newcode45
src/execution.h:45: // exception is kept pending on the isolate.
On 2017/01/17 at 09:54:23, Yang wrote:
> Wait... if exception_out is nullptr, TryCall behaves the same as Call?

no, Call() schedules the exception, TryCall leaves it pending

tried to clarify the comment

[commit-bot: I haz the power, 2017-01-17 10:24:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 10:52:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 10:52:54]

Dry run: This issue passed the CQ dry run.

[jochen (gone - plz use gerrit), 2017-01-17 11:30:05]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 11:30:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-01-17 11:30:14]

ptal

[commit-bot: I haz the power, 2017-01-17 11:58:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 11:58:14]

Dry run: This issue passed the CQ dry run.

[Yang, 2017-01-17 12:38:36]

On 2017/01/17 11:30:14, jochen wrote:
> ptal

lgtm.

[jochen (gone - plz use gerrit), 2017-01-17 12:59:22]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-01-17 12:59:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 13:01:04]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484657962620510,
"parent_rev": "bb71555e2e41678897187f3d0c0f42d742865305", "commit_rev":
"0389df514d48c6394f606bf4e5b9b0b0cb134d1b"}

[commit-bot: I haz the power, 2017-01-17 13:01:08]

Description was changed from

==========
Assert that context creation doesn't throw

Instead, it is supposed to just return an empty context if it failed.
Also don't invoke interceptors (we don't for the parts that deserialize
from the snapshot anyways).

BUG=v8:5830
R=yangguo@chromium.org
==========

to

==========
Assert that context creation doesn't throw

Instead, it is supposed to just return an empty context if it failed.
Also don't invoke interceptors (we don't for the parts that deserialize
from the snapshot anyways).

BUG=v8:5830
R=yangguo@chromium.org

Review-Url: https://codereview.chromium.org/2636903002
Cr-Commit-Position: refs/heads/master@{#42404}
Committed:
https://chromium.googlesource.com/v8/v8/+/0389df514d48c6394f606bf4e5b9b0b0cb1...
==========

[commit-bot: I haz the power, 2017-01-17 13:01:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/0389df514d48c6394f606bf4e5b9b0b0cb1...