Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: src/debug/debug.cc

Issue 2636903002: Assert that context creation doesn't throw (Closed)
Patch Set: updates Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler.cc ('k') | src/execution.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/debug.cc
diff --git a/src/debug/debug.cc b/src/debug/debug.cc
index 6969c06a17d752797851f4d95dd68e49b1bfb9fc..5cb9c6f8b2d554fc7e096a915f881bafe42390c7 100644
--- a/src/debug/debug.cc
+++ b/src/debug/debug.cc
@@ -655,7 +655,10 @@ MaybeHandle<Object> Debug::CallFunction(const char* name, int argc,
Handle<JSFunction> fun = Handle<JSFunction>::cast(
JSReceiver::GetProperty(isolate_, holder, name).ToHandleChecked());
Handle<Object> undefined = isolate_->factory()->undefined_value();
- return Execution::TryCall(isolate_, fun, undefined, argc, args);
+ MaybeHandle<Object> maybe_exception;
+ return Execution::TryCall(isolate_, fun, undefined, argc, args,
+ Execution::MessageHandling::kReport,
+ &maybe_exception);
}
@@ -2091,9 +2094,9 @@ void Debug::NotifyMessageHandler(v8::DebugEvent event,
Handle<Object> answer_value;
Handle<String> answer;
MaybeHandle<Object> maybe_exception;
- MaybeHandle<Object> maybe_result =
- Execution::TryCall(isolate_, process_debug_request, cmd_processor, 1,
- request_args, &maybe_exception);
+ MaybeHandle<Object> maybe_result = Execution::TryCall(
+ isolate_, process_debug_request, cmd_processor, 1, request_args,
+ Execution::MessageHandling::kReport, &maybe_exception);
if (maybe_result.ToHandle(&answer_value)) {
if (answer_value->IsUndefined(isolate_)) {
@@ -2491,8 +2494,10 @@ v8::Local<v8::String> MessageImpl::GetJSON() const {
return v8::Local<v8::String>();
}
- MaybeHandle<Object> maybe_json =
- Execution::TryCall(isolate, fun, event_data_, 0, NULL);
+ MaybeHandle<Object> maybe_exception;
+ MaybeHandle<Object> maybe_json = Execution::TryCall(
+ isolate, fun, event_data_, 0, nullptr,
+ Execution::MessageHandling::kReport, &maybe_exception);
Handle<Object> json;
if (!maybe_json.ToHandle(&json) || !json->IsString()) {
return v8::Local<v8::String>();
« no previous file with comments | « src/compiler.cc ('k') | src/execution.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698