[wasm] Internal Instantiate function should not take memory as an arg from wasm

[wasm] Internal Instantiate function should not take memory as an arg from wasm

BUG=5823
R=bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2636803002
Cr-Commit-Position: refs/heads/master@{#42355}
Committed: https://chromium.googlesource.com/v8/v8/+/ca03447cae335dfd5265da2be812b9b1a8cda6fb

[gdeepti, 2017-01-15 08:26:35]

The CQ bit was checked by gdeepti@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 08:26:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gdeepti, 2017-01-15 08:27:43]

Description was changed from

==========
WebAssembly.Instance constructor should not take memory as an extra argument

BUG=5823

R=bradnelson@chromium.org
==========

to

==========
[wasm] WebAssembly.Instance constructor should not take memory as an extra
argument

BUG=5823

R=bradnelson@chromium.org
==========

[commit-bot: I haz the power, 2017-01-15 08:52:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 08:52:36]

Dry run: This issue passed the CQ dry run.

[titzer, 2017-01-15 19:56:32]

titzer@chromium.org changed reviewers:
+ titzer@chromium.org

[titzer, 2017-01-15 19:56:33]

Can you add some tests for the new behavior?

[gdeepti, 2017-01-15 21:05:00]

On 2017/01/15 19:56:33, titzer wrote:
> Can you add some tests for the new behavior?

The title for this is misleading (fixed now) - the Instance constructor was not
really taking an extra parameter, it was just abstracting the memory out and
sending it as an extra arg to the internal instantiate function so this CL is
just removing dead code so not really sure how to test it as there are no API
changes

[gdeepti, 2017-01-15 21:06:24]

Description was changed from

==========
[wasm] WebAssembly.Instance constructor should not take memory as an extra
argument

BUG=5823

R=bradnelson@chromium.org
==========

to

==========
[wasm] Internal Instantiate function should not take memory as an arg from wasm

BUG=5823

R=bradnelson@chromium.org
==========

[titzer, 2017-01-15 21:14:29]

On 2017/01/15 21:05:00, gdeepti wrote:
> On 2017/01/15 19:56:33, titzer wrote:
> > Can you add some tests for the new behavior?
> 
> The title for this is misleading (fixed now) - the Instance constructor was
not
> really taking an extra parameter, it was just abstracting the memory out and
> sending it as an extra arg to the internal instantiate function so this CL is
> just removing dead code so not really sure how to test it as there are no API
> changes

Ok, thanks. LGTM

[gdeepti, 2017-01-16 08:28:32]

The CQ bit was checked by gdeepti@chromium.org

[commit-bot: I haz the power, 2017-01-16 08:28:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 08:58:26]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484555312975730, "parent_rev":
"11cf146610a36d71c138864cc3685706992a2733", "commit_rev":
"ca03447cae335dfd5265da2be812b9b1a8cda6fb"}

[commit-bot: I haz the power, 2017-01-16 08:58:32]

Description was changed from

==========
[wasm] Internal Instantiate function should not take memory as an arg from wasm

BUG=5823

R=bradnelson@chromium.org
==========

to

==========
[wasm] Internal Instantiate function should not take memory as an arg from wasm

BUG=5823

R=bradnelson@chromium.org

Review-Url: https://codereview.chromium.org/2636803002
Cr-Commit-Position: refs/heads/master@{#42355}
Committed:
https://chromium.googlesource.com/v8/v8/+/ca03447cae335dfd5265da2be812b9b1a8c...
==========

[commit-bot: I haz the power, 2017-01-16 08:58:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/ca03447cae335dfd5265da2be812b9b1a8c...