src/wasm/wasm-module.h - Issue 2636803002: [wasm] Internal Instantiate function should not take memory as an arg from wasm

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/wasm/wasm-module.h

Issue 2636803002: [wasm] Internal Instantiate function should not take memory as an arg from wasm (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/wasm/wasm-module.h

diff --git a/src/wasm/wasm-module.h b/src/wasm/wasm-module.h

index ff680711df636ce4b0faa52c59d1f344c79c3211..17263ec35bfcee08c93c21e8c6ed0bf7eccb62c5 100644

--- a/src/wasm/wasm-module.h

+++ b/src/wasm/wasm-module.h

@@ -218,7 +218,7 @@ struct V8_EXPORT_PRIVATE WasmModule {

static MaybeHandle<WasmInstanceObject> Instantiate(

Isolate* isolate, ErrorThrower* thrower,

Handle<WasmModuleObject> wasm_module, Handle<JSReceiver> ffi,

- Handle<JSArrayBuffer> memory);

+ Handle<JSArrayBuffer> memory = Handle<JSArrayBuffer>::null());

MaybeHandle<WasmCompiledModule> CompileFunctions(

Isolate* isolate, Handle<Managed<WasmModule>> module_wrapper,

« no previous file with comments | « src/wasm/wasm-js.cc ('k') | test/common/wasm/wasm-module-runner.cc » ('j') | no next file with comments »