Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Issue 2636493003: Revert of [compiler] Support Object.create(null) inlining in TF (Closed)

Created:
3 years, 11 months ago by Camillo Bruni
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [compiler] Support Object.create(null) inlining in TF (patchset #5 id:80001 of https://codereview.chromium.org/2622723003/ ) Reason for revert: Breaks buildbot: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20-%20avx2/builds/13399/steps/Benchmarks/logs/stdio Original issue's description: > [compiler] Support Object.create(null) inlining in TF > > In the ideal case, this will speed up Object.create(null) by ~10x. > > Drive-by-fix: Spread usage of new IsSpecialReceiverMap() and > IsSpecialReceiverInstanceType(InstanceType) helpers. > > BUG=v8:5788 > > Review-Url: https://codereview.chromium.org/2622723003 > Cr-Commit-Position: refs/heads/master@{#42321} > Committed: https://chromium.googlesource.com/v8/v8/+/ff7063c7d5d8ad8eafcce3da59e65d7fe2b4f915 TBR=jarin@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5788 Review-Url: https://codereview.chromium.org/2636493003 Cr-Commit-Position: refs/heads/master@{#42326} Committed: https://chromium.googlesource.com/v8/v8/+/83d5b65ae053fb59eeb2cafcc2566e749a3ca4b7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -223 lines) Patch
M src/compiler/access-builder.h View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/access-builder.cc View 1 chunk +0 lines, -62 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/js-builtin-reducer.cc View 3 chunks +0 lines, -97 lines 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 3 chunks +1 line, -6 lines 0 comments Download
M src/objects.cc View 2 chunks +2 lines, -32 lines 0 comments Download
M src/objects-inl.h View 2 chunks +0 lines, -9 lines 0 comments Download
M src/runtime/runtime-array.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 chunk +24 lines, -2 lines 0 comments Download
M src/value-serializer.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
Camillo Bruni
Created Revert of [compiler] Support Object.create(null) inlining in TF
3 years, 11 months ago (2017-01-13 12:55:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636493003/1
3 years, 11 months ago (2017-01-13 12:55:57 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:56:13 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/83d5b65ae053fb59eeb2cafcc2566e749a3...

Powered by Google App Engine
This is Rietveld 408576698