Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2622723003: [compiler] Support Object.create(null) inlining in TF (Closed)

Created:
3 years, 11 months ago by Camillo Bruni
Modified:
3 years, 11 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[compiler] Support Object.create(null) inlining in TF In the ideal case, this will speed up Object.create(null) by ~10x. Drive-by-fix: Spread usage of new IsSpecialReceiverMap() and IsSpecialReceiverInstanceType(InstanceType) helpers. BUG=v8:5788 Review-Url: https://codereview.chromium.org/2622723003 Cr-Commit-Position: refs/heads/master@{#42336} Committed: https://chromium.googlesource.com/v8/v8/+/c60ec4e1112c4ccb304ca584c00a1849ae663799

Patch Set 1 #

Patch Set 2 : remove unused variable #

Patch Set 3 : restrict reduction to valid heap constants #

Patch Set 4 : formatting #

Patch Set 5 : reverting helper changes #

Patch Set 6 : initializing all object fields #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -37 lines) Patch
M src/compiler/access-builder.h View 1 2 3 4 5 3 chunks +13 lines, -1 line 0 comments Download
M src/compiler/access-builder.cc View 1 2 3 4 5 3 chunks +74 lines, -2 lines 0 comments Download
M src/compiler/js-builtin-reducer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/js-builtin-reducer.cc View 1 2 3 4 5 3 chunks +115 lines, -0 lines 0 comments Download
M src/lookup.h View 1 chunk +1 line, -1 line 0 comments Download
M src/lookup.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M src/objects.h View 1 2 3 4 5 3 chunks +6 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 4 5 2 chunks +32 lines, -2 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 2 chunks +9 lines, -0 lines 0 comments Download
M src/runtime/runtime-array.cc View 1 2 3 2 chunks +2 lines, -4 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 2 3 4 5 1 chunk +2 lines, -24 lines 0 comments Download
M src/value-serializer.cc View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 30 (22 generated)
Camillo Bruni
PTAL Seems like the GC issues I've observed were unrelated to my changes as they ...
3 years, 11 months ago (2017-01-13 10:51:09 UTC) #9
Jarin
lgtm (even though I cannot claim I fully understand the stuff in objects.cc).
3 years, 11 months ago (2017-01-13 10:59:38 UTC) #10
Camillo Bruni
On 2017/01/13 at 10:59:38, jarin wrote: > lgtm (even though I cannot claim I fully ...
3 years, 11 months ago (2017-01-13 11:48:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622723003/80001
3 years, 11 months ago (2017-01-13 12:01:54 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://chromium.googlesource.com/v8/v8/+/ff7063c7d5d8ad8eafcce3da59e65d7fe2b4f915
3 years, 11 months ago (2017-01-13 12:04:45 UTC) #18
Camillo Bruni
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/2636493003/ by cbruni@chromium.org. ...
3 years, 11 months ago (2017-01-13 12:55:48 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2622723003/100001
3 years, 11 months ago (2017-01-13 16:44:58 UTC) #27
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 16:47:21 UTC) #30
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/v8/v8/+/c60ec4e1112c4ccb304ca584c00a1849ae6...

Powered by Google App Engine
This is Rietveld 408576698