Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1077)

Unified Diff: cc/blink/web_layer_impl.cc

Issue 2636253002: Handle nested position:sticky elements (Closed)
Patch Set: First attempt at compositing side, does NOT work properly yet Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/layers/layer_sticky_position_constraint.h » ('j') | cc/trees/property_tree.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blink/web_layer_impl.cc
diff --git a/cc/blink/web_layer_impl.cc b/cc/blink/web_layer_impl.cc
index 73e62b3e66fc0f018aa19bf2484402d08a1b69af..ad60d0cf7fbc79934eb15ef4fc0e6e89c3e9620f 100644
--- a/cc/blink/web_layer_impl.cc
+++ b/cc/blink/web_layer_impl.cc
@@ -398,6 +398,15 @@ static cc::LayerStickyPositionConstraint ToStickyPositionConstraint(
web_constraint.scrollContainerRelativeStickyBoxRect;
constraint.scroll_container_relative_containing_block_rect =
web_constraint.scrollContainerRelativeContainingBlockRect;
+ constraint.nearest_sticky_element_shifting_sticky_box =
+ web_constraint.nearestStickyElementShiftingStickyBox
+ ? web_constraint.nearestStickyElementShiftingStickyBox->ccLayer()
+ : nullptr;
+ constraint.nearest_sticky_element_shifting_containing_block =
+ web_constraint.nearestStickyElementShiftingContainingBlock
+ ? web_constraint.nearestStickyElementShiftingContainingBlock
+ ->ccLayer()
+ : nullptr;
return constraint;
}
void WebLayerImpl::setStickyPositionConstraint(
« no previous file with comments | « no previous file | cc/layers/layer_sticky_position_constraint.h » ('j') | cc/trees/property_tree.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698