Handle nested position:sticky elements

cc/blink/web_layer_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/blink/web_layer_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <utility>
@@ skipping 360 matching lines @@
   web_constraint.leftOffset = constraint.left_offset;
   web_constraint.rightOffset = constraint.right_offset;
   web_constraint.topOffset = constraint.top_offset;
   web_constraint.bottomOffset = constraint.bottom_offset;
   web_constraint.parentRelativeStickyBoxOffset =
       constraint.parent_relative_sticky_box_offset;
   web_constraint.scrollContainerRelativeStickyBoxRect =
       constraint.scroll_container_relative_sticky_box_rect;
   web_constraint.scrollContainerRelativeContainingBlockRect =
       constraint.scroll_container_relative_containing_block_rect;
   return web_constraint;

[flackr, 2017/02/02 18:18:11]

We need to copy the ancestor pointers here too right?

[smcgruer, 2017/02/02 20:21:26]

Yes, although I'm not immediately clear how to convert cc::Layer back to
WebLayer.

Added TODO so I dont forget.

 }
 static cc::LayerStickyPositionConstraint ToStickyPositionConstraint(
     const blink::WebLayerStickyPositionConstraint& web_constraint) {
   cc::LayerStickyPositionConstraint constraint;
   constraint.is_sticky = web_constraint.isSticky;
   constraint.is_anchored_left = web_constraint.isAnchoredLeft;
   constraint.is_anchored_right = web_constraint.isAnchoredRight;
   constraint.is_anchored_top = web_constraint.isAnchoredTop;
   constraint.is_anchored_bottom = web_constraint.isAnchoredBottom;
   constraint.left_offset = web_constraint.leftOffset;
   constraint.right_offset = web_constraint.rightOffset;
   constraint.top_offset = web_constraint.topOffset;
   constraint.bottom_offset = web_constraint.bottomOffset;
   constraint.parent_relative_sticky_box_offset =
       web_constraint.parentRelativeStickyBoxOffset;
   constraint.scroll_container_relative_sticky_box_rect =
       web_constraint.scrollContainerRelativeStickyBoxRect;
   constraint.scroll_container_relative_containing_block_rect =
       web_constraint.scrollContainerRelativeContainingBlockRect;
+  constraint.nearest_sticky_element_shifting_sticky_box =
+      web_constraint.nearestStickyElementShiftingStickyBox
+          ? web_constraint.nearestStickyElementShiftingStickyBox->ccLayer()
+          : nullptr;
+  constraint.nearest_sticky_element_shifting_containing_block =
+      web_constraint.nearestStickyElementShiftingContainingBlock
+          ? web_constraint.nearestStickyElementShiftingContainingBlock
+                ->ccLayer()
+          : nullptr;
   return constraint;
 }
 void WebLayerImpl::setStickyPositionConstraint(
     const blink::WebLayerStickyPositionConstraint& constraint) {
   layer_->SetStickyPositionConstraint(ToStickyPositionConstraint(constraint));
 }
 blink::WebLayerStickyPositionConstraint WebLayerImpl::stickyPositionConstraint()
     const {
   return ToWebLayerStickyPositionConstraint(
       layer_->sticky_position_constraint());
@@ skipping 65 matching lines @@
 
 void WebLayerImpl::setPreferredRasterBounds(const WebSize& bounds) {
   layer_->SetPreferredRasterBounds(bounds);
 }
 
 void WebLayerImpl::clearPreferredRasterBounds() {
   layer_->ClearPreferredRasterBounds();
 }
 
 }  // namespace cc_blink