Add a feature for Location Settings Dialog.

Add a feature for Location Settings Dialog.

BUG=672301
Review-Url: https://codereview.chromium.org/2636093002
Cr-Commit-Position: refs/heads/master@{#444344}
Committed: https://chromium.googlesource.com/chromium/src/+/db5f41b6556a48763020ac929f901a507682cf04

[kcarattini, 2017-01-16 23:46:37]

kcarattini@chromium.org changed reviewers:
+ raymes@chromium.org

[raymes, 2017-01-18 04:27:01]

lgtm

https://codereview.chromium.org/2636093002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2636093002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:110: // Enables or disables the Location
Settings Dialog.
Maybe add a note that the LSD is the Android system-level geolocation permission
prompt (if that's accurate :)

[kcarattini, 2017-01-18 04:40:08]

kcarattini@chromium.org changed reviewers:
+ isherman@chromium.org

[kcarattini, 2017-01-18 04:40:09]

Thanks, Raymes!
+Ilya for histograms.xml

https://codereview.chromium.org/2636093002/diff/20001/chrome/common/chrome_fe...
File chrome/common/chrome_features.cc (right):

https://codereview.chromium.org/2636093002/diff/20001/chrome/common/chrome_fe...
chrome/common/chrome_features.cc:110: // Enables or disables the Location
Settings Dialog.
On 2017/01/18 04:27:01, raymes wrote:
> Maybe add a note that the LSD is the Android system-level geolocation
permission
> prompt (if that's accurate :) 

Done.

[Ilya Sherman, 2017-01-18 08:01:30]

histograms.xml lgtm

[kcarattini, 2017-01-18 12:36:06]

The CQ bit was checked by kcarattini@chromium.org

[kcarattini, 2017-01-18 12:36:07]

The patchset sent to the CQ was uploaded after l-g-t-m from raymes@chromium.org
Link to the patchset: https://codereview.chromium.org/2636093002/#ps40001
(title: "Update comment.")

[commit-bot: I haz the power, 2017-01-18 12:36:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 13:24:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484742966700850,
"parent_rev": "9a91abd16665860a7ab53a307b8e87c5783fbc6c", "commit_rev":
"db5f41b6556a48763020ac929f901a507682cf04"}

[commit-bot: I haz the power, 2017-01-18 13:24:43]

Description was changed from

==========
Add a feature for Location Settings Dialog.

BUG=672301
==========

to

==========
Add a feature for Location Settings Dialog.

BUG=672301

Review-Url: https://codereview.chromium.org/2636093002
Cr-Commit-Position: refs/heads/master@{#444344}
Committed:
https://chromium.googlesource.com/chromium/src/+/db5f41b6556a48763020ac929f90...
==========

[commit-bot: I haz the power, 2017-01-18 13:24:44]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/db5f41b6556a48763020ac929f90...