Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 2636093002: Add a feature for Location Settings Dialog. (Closed)
Patch Set: Update comment. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_features.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2161 matching lines...) Expand 10 before | Expand all | Expand 10 after
2172 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE( 2172 kOsAndroid, FEATURE_WITH_VARIATIONS_VALUE_TYPE(
2173 autofill::kAutofillCreditCardPopupLayout, 2173 autofill::kAutofillCreditCardPopupLayout,
2174 kAutofillCreditCardPopupLayoutFeatureVariations, 2174 kAutofillCreditCardPopupLayoutFeatureVariations,
2175 "AutofillCreditCardPopupLayout")}, 2175 "AutofillCreditCardPopupLayout")},
2176 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER, 2176 {"native-android-history-manager", IDS_NATIVE_ANDROID_HISTORY_MANAGER,
2177 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid, 2177 IDS_NATIVE_ANDROID_HISTORY_MANAGER_DESCRIPTION, kOsAndroid,
2178 FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)}, 2178 FEATURE_VALUE_TYPE(chrome::android::kNativeAndroidHistoryManager)},
2179 #endif // OS_ANDROID 2179 #endif // OS_ANDROID
2180 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME, 2180 {"enable-faster-location-reload", IDS_FLAGS_FASTER_LOCATION_RELOAD_NAME,
2181 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll, 2181 IDS_FLAGS_FASTER_LOCATION_RELOAD_DESCRIPTION, kOsAll,
2182 FEATURE_VALUE_TYPE(features::kFasterLocationReload)} 2182 FEATURE_VALUE_TYPE(features::kFasterLocationReload)},
2183 #if defined(OS_ANDROID)
2184 {"lsd-permission-prompt", IDS_FLAGS_LSD_PERMISSION_PROMPT_NAME,
2185 IDS_FLAGS_LSD_PERMISSION_PROMPT_DESCRIPTION, kOsAndroid,
2186 FEATURE_VALUE_TYPE(features::kLsdPermissionPrompt)},
2187 #endif
2188
2183 2189
2184 // NOTE: Adding new command-line switches requires adding corresponding 2190 // NOTE: Adding new command-line switches requires adding corresponding
2185 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2191 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2186 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2192 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2187 }; 2193 };
2188 2194
2189 class FlagsStateSingleton { 2195 class FlagsStateSingleton {
2190 public: 2196 public:
2191 FlagsStateSingleton() 2197 FlagsStateSingleton()
2192 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {} 2198 : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
2382 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0; 2388 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
2383 2389
2384 const FeatureEntry* GetFeatureEntries(size_t* count) { 2390 const FeatureEntry* GetFeatureEntries(size_t* count) {
2385 *count = arraysize(kFeatureEntries); 2391 *count = arraysize(kFeatureEntries);
2386 return kFeatureEntries; 2392 return kFeatureEntries;
2387 } 2393 }
2388 2394
2389 } // namespace testing 2395 } // namespace testing
2390 2396
2391 } // namespace about_flags 2397 } // namespace about_flags
OLDNEW
« no previous file with comments | « chrome/app/generated_resources.grd ('k') | chrome/common/chrome_features.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698