[Autofill and payments] Redesign Autofill settings UIs

Redesign Autofill settings UIs

BUG=679743
Review-Url: https://codereview.chromium.org/2636023002
Cr-Commit-Position: refs/heads/master@{#445750}
Committed: https://chromium.googlesource.com/chromium/src/+/6dbc00f485873cc326e3742f65fd7313d7af6aaa

[gogerald1, 2017-01-16 21:49:56]

Patchset #1 (id:1) has been deleted

[gogerald1, 2017-01-16 21:50:03]

Patchset #1 (id:20001) has been deleted

[gogerald1, 2017-01-16 21:50:15]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 21:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-01-16 21:52:18]

Description was changed from

==========
revamp autofill preference

BUG=
==========

to

==========
Revamp autofill preferences

BUG=
==========

[commit-bot: I haz the power, 2017-01-16 22:42:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 22:42:05]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-01-20 18:23:37]

Patchset #1 (id:40001) has been deleted

[gogerald1, 2017-01-20 18:23:44]

Patchset #1 (id:60001) has been deleted

[gogerald1, 2017-01-20 18:23:54]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 18:24:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-01-20 19:01:13]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 19:01:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-01-20 19:10:35]

Patchset #1 (id:80001) has been deleted

[gogerald1, 2017-01-20 19:11:27]

Description was changed from

==========
Revamp autofill preferences

BUG=
==========

to

==========
Redesign autofill settings UIs

BUG=679743
==========

[gogerald1, 2017-01-20 19:12:10]

Description was changed from

==========
Redesign autofill settings UIs

BUG=679743
==========

to

==========
Redesign Autofill settings UIs

BUG=679743
==========

[gogerald1, 2017-01-20 19:18:31]

gogerald@chromium.org changed reviewers:
+ dfalcantara@chromium.org, mathp@chromium.org

[gogerald1, 2017-01-20 19:18:32]

Hi mathp@ and dfalcantara@, PTAL. 

Note that the strings might get minor changes later which is expected to have
determined information at next Monday.

[gogerald1, 2017-01-20 20:19:12]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2017-01-20 20:19:32]

PTAL a look of the new patch with minor changes in
autofill_and_payments_preferences.xml

[commit-bot: I haz the power, 2017-01-20 20:19:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-20 21:20:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-20 21:20:18]

Dry run: This issue passed the CQ dry run.

[Mathieu, 2017-01-20 21:59:51]

lgtm, thanks for doing this

https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:42:
if (profile.getIsLocal()) {
Could we set a TODO to use the AddressEditor from PaymentRequest? 

when tapping on an item we could do:
mAddressEditor.edit(item, ...some callback...) and that would do the trick, I'm
pretty sure.

[gogerald1, 2017-01-20 23:07:16]

https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:42:
if (profile.getIsLocal()) {
On 2017/01/20 21:59:51, Mathieu Perreault wrote:
> Could we set a TODO to use the AddressEditor from PaymentRequest? 
> 
> when tapping on an item we could do:
> mAddressEditor.edit(item, ...some callback...) and that would do the trick,
I'm
> pretty sure.

Create a bug to follow it, http://crbug.com/683392

[gogerald1, 2017-01-20 23:07:25]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-20 23:07:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-21 00:15:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-21 00:15:30]

Dry run: This issue passed the CQ dry run.

[gone, 2017-01-23 21:26:17]

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
File chrome/android/java/res/xml/autofill_and_payments_preferences.xml (right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
chrome/android/java/res/xml/autofill_and_payments_preferences.xml:10:
android:title="@string/autofill_switch"/>
space before />

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
chrome/android/java/res/xml/autofill_and_payments_preferences.xml:15:
android:fragment="org.chromium.chrome.browser.preferences.autofill.AutofillProfilesFragment"/>
space before />

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
chrome/android/java/res/xml/autofill_and_payments_preferences.xml:20:
android:fragment="org.chromium.chrome.browser.preferences.autofill.AutofillCreditCardsFragment"/>
Ditto

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:831:
* Checks whether has profiles.
whether what has profiles?

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:840:
* Checks whether has credit cards.
Ditto.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java:44:
// Add an item on the current page...
Comment's not useful and shouldn't end with an ellipsis.  Does this add a
preference for each credit card?  Should the comment say that instead?

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java:62:
Preference pref = new Preference(getActivity());
Add a comment about what this block does.  Looks like it's setting up the "Add
new credit card" button.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:44:
// Add an item on the current page...
Make comment explain what this is doing.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:61:
Preference pref = new Preference(getActivity());
Add comment about setting up the add address button.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:271: <message
name="IDS_PREFS_AUTOFILL_AND_PAYMENTS" desc="Title of Autofill and payments
settings prefrences. [CHAR-LIMIT=32]">
I'd remove the character limit.  Preferences automatically wrap when their
descriptions are too long, which happens on the Privacy preferences already.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:280: <message
name="IDS_AUTOFILL_UPDATE_PROFILES_SUMMARY" desc="Summary of the preference to
list profiles (which contain the user's name, address, etc) that can be
automatically filled into web page forms. Explains what users can do by clicking
this preference.">
These description strings aren't useful for translation.  Maybe try strings
along these lines, instead?

"Informs users that clicking this button allows them to add/remove/edit their
stored addresses."

"Informs users that clicking this button allows them to add new addresses to
their profile."

"Informs users that clicking this button allows them to add/remove/edit their
stored credit card information."

"Informs users that clicking this button allows them to add new credit card
information to their profile."

[gogerald1, 2017-01-23 21:59:42]

Patchset #4 (id:160001) has been deleted

[gogerald1, 2017-01-23 22:03:35]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[gogerald1, 2017-01-23 22:04:18]

Hi dfalcantara@, please take another look,

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
File chrome/android/java/res/xml/autofill_and_payments_preferences.xml (right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
chrome/android/java/res/xml/autofill_and_payments_preferences.xml:10:
android:title="@string/autofill_switch"/>
On 2017/01/23 21:26:16, dfalcantara (load balance plz) wrote:
> space before />

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
chrome/android/java/res/xml/autofill_and_payments_preferences.xml:15:
android:fragment="org.chromium.chrome.browser.preferences.autofill.AutofillProfilesFragment"/>
On 2017/01/23 21:26:16, dfalcantara (load balance plz) wrote:
> space before />

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/re...
chrome/android/java/res/xml/autofill_and_payments_preferences.xml:20:
android:fragment="org.chromium.chrome.browser.preferences.autofill.AutofillCreditCardsFragment"/>
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> Ditto

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:831:
* Checks whether has profiles.
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> whether what has profiles?

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:840:
* Checks whether has credit cards.
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> Ditto.

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java:44:
// Add an item on the current page...
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> Comment's not useful and shouldn't end with an ellipsis.  Does this add a
> preference for each credit card?  Should the comment say that instead?

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java:62:
Preference pref = new Preference(getActivity());
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> Add a comment about what this block does.  Looks like it's setting up the "Add
> new credit card" button.

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:44:
// Add an item on the current page...
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> Make comment explain what this is doing.

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:61:
Preference pref = new Preference(getActivity());
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> Add comment about setting up the add address button.

Done.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:271: <message
name="IDS_PREFS_AUTOFILL_AND_PAYMENTS" desc="Title of Autofill and payments
settings prefrences. [CHAR-LIMIT=32]">
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> I'd remove the character limit.  Preferences automatically wrap when their
> descriptions are too long, which happens on the Privacy preferences already.

This string is also be used as the title of the preference fragment, it might be
better restrict the length if it.

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:280: <message
name="IDS_AUTOFILL_UPDATE_PROFILES_SUMMARY" desc="Summary of the preference to
list profiles (which contain the user's name, address, etc) that can be
automatically filled into web page forms. Explains what users can do by clicking
this preference.">
On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> These description strings aren't useful for translation.  Maybe try strings
> along these lines, instead?
> 
> "Informs users that clicking this button allows them to add/remove/edit their
> stored addresses."
> 
> "Informs users that clicking this button allows them to add new addresses to
> their profile."
> 
> "Informs users that clicking this button allows them to add/remove/edit their
> stored credit card information."
> 
> "Informs users that clicking this button allows them to add new credit card
> information to their profile."

Done.

[commit-bot: I haz the power, 2017-01-23 22:04:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 23:34:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:34:34]

Dry run: This issue passed the CQ dry run.

[gone, 2017-01-23 23:44:52]

lgtm % comments

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/st...
chrome/android/java/strings/android_chrome_strings.grd:271: <message
name="IDS_PREFS_AUTOFILL_AND_PAYMENTS" desc="Title of Autofill and payments
settings prefrences. [CHAR-LIMIT=32]">
On 2017/01/23 22:04:18, gogerald1 wrote:
> On 2017/01/23 21:26:17, dfalcantara (load balance plz) wrote:
> > I'd remove the character limit.  Preferences automatically wrap when their
> > descriptions are too long, which happens on the Privacy preferences already.
> 
> This string is also be used as the title of the preference fragment, it might
be
> better restrict the length if it.

Acknowledged.

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:831:
* Checks whether has profiles in autofill PersonalDataManager.
Checks whether the Autofill PersonalDataManager has profiles.

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:840:
* Checks whether has credit cards in autofill PersonalDataManager.
Similar to above.

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java:44:
// Add a preferemce for the credit card.
preference

[gogerald1, 2017-01-24 01:48:36]

Patchset #5 (id:200001) has been deleted

[gogerald1, 2017-01-24 02:38:42]

Patchset #5 (id:220001) has been deleted

[gogerald1, 2017-01-24 02:43:13]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 02:43:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 04:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 04:14:27]

Dry run: This issue passed the CQ dry run.

[gogerald1, 2017-01-24 15:27:35]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 15:27:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 15:31:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:31:54]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_cronet on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_cron...)
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[gogerald1, 2017-01-24 15:35:02]

Patchset #5 (id:240001) has been deleted

[gogerald1, 2017-01-24 15:44:11]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 15:44:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2017-01-24 15:46:35]

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java
(right):

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:831:
* Checks whether has profiles in autofill PersonalDataManager.
On 2017/01/23 23:44:52, dfalcantara (load balance plz) wrote:
> Checks whether the Autofill PersonalDataManager has profiles.

Done.

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:840:
* Checks whether has credit cards in autofill PersonalDataManager.
On 2017/01/23 23:44:52, dfalcantara (load balance plz) wrote:
> Similar to above.

Done.

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java
(right):

https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/sr...
chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java:44:
// Add a preferemce for the credit card.
On 2017/01/23 23:44:52, dfalcantara (load balance plz) wrote:
> preference

Done.

[commit-bot: I haz the power, 2017-01-24 15:48:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:48:19]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[gogerald1, 2017-01-24 15:49:56]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2017-01-24 15:49:57]

The patchset sent to the CQ was uploaded after l-g-t-m from mathp@chromium.org,
dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2636023002/#ps280001
(title: "rebase")

[commit-bot: I haz the power, 2017-01-24 15:50:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 15:53:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 15:53:51]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[gogerald1, 2017-01-24 16:47:01]

The CQ bit was checked by gogerald@chromium.org

[commit-bot: I haz the power, 2017-01-24 16:47:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 17:27:55]

CQ is committing da patch.

Bot data: {"patchset_id": 280001, "attempt_start_ts": 1485276421876940,
"parent_rev": "6771b80c488c2c1b685ab2f674928ee09654ab15", "commit_rev":
"6dbc00f485873cc326e3742f65fd7313d7af6aaa"}

[commit-bot: I haz the power, 2017-01-24 17:28:43]

Description was changed from

==========
Redesign Autofill settings UIs

BUG=679743
==========

to

==========
Redesign Autofill settings UIs

BUG=679743

Review-Url: https://codereview.chromium.org/2636023002
Cr-Commit-Position: refs/heads/master@{#445750}
Committed:
https://chromium.googlesource.com/chromium/src/+/6dbc00f485873cc326e3742f65fd...
==========

[commit-bot: I haz the power, 2017-01-24 17:28:44]

Committed patchset #6 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/6dbc00f485873cc326e3742f65fd...