Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 2636023002: [Autofill and payments] Redesign Autofill settings UIs (Closed)

Created:
3 years, 11 months ago by gogerald1
Modified:
3 years, 11 months ago
Reviewers:
Mathieu, gone
CC:
chromium-reviews, rouslan+payments_chromium.org, rouslan+autofill_chromium.org, sebsg+autofillwatch_chromium.org, browser-components-watch_chromium.org, gogerald+paymentswatch_chromium.org, mathp+autofillwatch_chromium.org, agrieve+watch_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, sebsg+paymentswatch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Redesign Autofill settings UIs BUG=679743 Review-Url: https://codereview.chromium.org/2636023002 Cr-Commit-Position: refs/heads/master@{#445750} Committed: https://chromium.googlesource.com/chromium/src/+/6dbc00f485873cc326e3742f65fd7313d7af6aaa

Patch Set 1 #

Patch Set 2 : remove switch preference summary #

Total comments: 2

Patch Set 3 : no need refresh in onCreate #

Total comments: 23

Patch Set 4 : address comments #

Total comments: 6

Patch Set 5 : address nits and update strings #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+331 lines, -278 lines) Patch
A chrome/android/java/res/xml/autofill_and_payments_preference_fragment_screen.xml View 1 chunk +6 lines, -0 lines 0 comments Download
A chrome/android/java/res/xml/autofill_and_payments_preferences.xml View 1 2 3 4 1 chunk +20 lines, -0 lines 0 comments Download
D chrome/android/java/res/xml/autofill_preferences.xml View 1 chunk +0 lines, -29 lines 0 comments Download
M chrome/android/java/res/xml/main_preferences.xml View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 3 4 5 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java View 1 2 3 4 5 chunks +27 lines, -6 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java View 1 2 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/MainPreferences.java View 1 chunk +0 lines, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/PreferenceCategoryWithButton.java View 1 chunk +0 lines, -58 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillAndPaymentsPreferences.java View 1 2 3 4 1 chunk +51 lines, -0 lines 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillCreditCardsFragment.java View 1 2 3 4 1 chunk +92 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillEditorBase.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillLocalCardEditor.java View 1 chunk +1 line, -1 line 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillPreferences.java View 1 chunk +0 lines, -165 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfileEditor.java View 1 chunk +1 line, -1 line 0 comments Download
A chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java View 1 2 3 4 1 chunk +91 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillServerProfilePreferences.java View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 3 4 5 1 chunk +7 lines, -4 lines 0 comments Download
M chrome/android/java_sources.gni View 1 2 3 4 5 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.h View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/autofill/android/personal_data_manager_android.cc View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 63 (51 generated)
gogerald1
Hi mathp@ and dfalcantara@, PTAL. Note that the strings might get minor changes later which ...
3 years, 11 months ago (2017-01-20 19:18:32 UTC) #18
gogerald1
PTAL a look of the new patch with minor changes in autofill_and_payments_preferences.xml
3 years, 11 months ago (2017-01-20 20:19:32 UTC) #20
Mathieu
lgtm, thanks for doing this https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java (right): https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java#newcode42 chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:42: if (profile.getIsLocal()) { Could ...
3 years, 11 months ago (2017-01-20 21:59:51 UTC) #24
gogerald1
https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java File chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java (right): https://codereview.chromium.org/2636023002/diff/120001/chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java#newcode42 chrome/android/java/src/org/chromium/chrome/browser/preferences/autofill/AutofillProfilesFragment.java:42: if (profile.getIsLocal()) { On 2017/01/20 21:59:51, Mathieu Perreault wrote: ...
3 years, 11 months ago (2017-01-20 23:07:16 UTC) #25
gone
https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/res/xml/autofill_and_payments_preferences.xml File chrome/android/java/res/xml/autofill_and_payments_preferences.xml (right): https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/res/xml/autofill_and_payments_preferences.xml#newcode10 chrome/android/java/res/xml/autofill_and_payments_preferences.xml:10: android:title="@string/autofill_switch"/> space before /> https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/res/xml/autofill_and_payments_preferences.xml#newcode15 chrome/android/java/res/xml/autofill_and_payments_preferences.xml:15: android:fragment="org.chromium.chrome.browser.preferences.autofill.AutofillProfilesFragment"/> space before ...
3 years, 11 months ago (2017-01-23 21:26:17 UTC) #30
gogerald1
Hi dfalcantara@, please take another look, https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/res/xml/autofill_and_payments_preferences.xml File chrome/android/java/res/xml/autofill_and_payments_preferences.xml (right): https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/res/xml/autofill_and_payments_preferences.xml#newcode10 chrome/android/java/res/xml/autofill_and_payments_preferences.xml:10: android:title="@string/autofill_switch"/> On 2017/01/23 ...
3 years, 11 months ago (2017-01-23 22:04:18 UTC) #33
gone
lgtm % comments https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/2636023002/diff/140001/chrome/android/java/strings/android_chrome_strings.grd#newcode271 chrome/android/java/strings/android_chrome_strings.grd:271: <message name="IDS_PREFS_AUTOFILL_AND_PAYMENTS" desc="Title of Autofill and ...
3 years, 11 months ago (2017-01-23 23:44:52 UTC) #37
gogerald1
https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java File chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java (right): https://codereview.chromium.org/2636023002/diff/180001/chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java#newcode831 chrome/android/java/src/org/chromium/chrome/browser/autofill/PersonalDataManager.java:831: * Checks whether has profiles in autofill PersonalDataManager. On ...
3 years, 11 months ago (2017-01-24 15:46:35 UTC) #51
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636023002/280001
3 years, 11 months ago (2017-01-24 15:50:10 UTC) #56
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/199594)
3 years, 11 months ago (2017-01-24 15:53:51 UTC) #58
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2636023002/280001
3 years, 11 months ago (2017-01-24 16:47:09 UTC) #60
commit-bot: I haz the power
3 years, 11 months ago (2017-01-24 17:28:44 UTC) #63
Message was sent while issue was closed.
Committed patchset #6 (id:280001) as
https://chromium.googlesource.com/chromium/src/+/6dbc00f485873cc326e3742f65fd...

Powered by Google App Engine
This is Rietveld 408576698