Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2635943002: Revert of mediaview: Enable by default. (Closed)

Created:
3 years, 11 months ago by pkalinnikov
Modified:
3 years, 11 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of mediaview: Enable by default. (patchset #1 id:1 of https://codereview.chromium.org/2638713002/ ) Reason for revert: ArcSessionManagerTest.ConsumerAccount and 3 more ArcSessionManagerTest.* tests are failing on "Linux Chromium OS ASan LSan Tests (1)" builder. Original issue's description: > mediaview: Enable by default. > > Now all required changes are in. Let us enable the feature by > default. > > BUG=chromium:671511 > TEST=Media view works on samus without flags > > Review-Url: https://codereview.chromium.org/2638713002 > Cr-Commit-Position: refs/heads/master@{#443855} > Committed: https://chromium.googlesource.com/chromium/src/+/6d266375ae1ebcd12933e946a1ce455fbec9b7b6 TBR=hidehiko@chromium.org,nya@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:671511 Review-Url: https://codereview.chromium.org/2635943002 Cr-Commit-Position: refs/heads/master@{#443888} Committed: https://chromium.googlesource.com/chromium/src/+/eff8ce80aa2744b1e0fc8ca69d1186d32c420655

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/chromeos/arc/fileapi/arc_media_view_util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
pkalinnikov
Created Revert of mediaview: Enable by default.
3 years, 11 months ago (2017-01-16 14:10:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635943002/1
3 years, 11 months ago (2017-01-16 14:10:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/eff8ce80aa2744b1e0fc8ca69d1186d32c420655
3 years, 11 months ago (2017-01-16 14:12:04 UTC) #6
Shuhei Takahashi
lgtm Sorry for breakage and thanks for the fix. I'll take a look at failure ...
3 years, 11 months ago (2017-01-17 03:24:49 UTC) #7
Shuhei Takahashi
3 years, 11 months ago (2017-01-17 06:58:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2630283003/ by nya@chromium.org.

The reason for reverting is: The issue has been resolved in
crrev.com/2639483003..

Powered by Google App Engine
This is Rietveld 408576698