Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(26)

Issue 2638713002: mediaview: Enable by default. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by Shuhei Takahashi
Modified:
5 months, 1 week ago
Reviewers:
hidehiko
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, tzik, hidehiko+watch_chromium.org, nhiroki, lhchavez+watch_chromium.org, oshima+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mediaview: Enable by default. Now all required changes are in. Let us enable the feature by default. BUG=chromium:671511 TEST=Media view works on samus without flags Review-Url: https://codereview.chromium.org/2638713002 Cr-Commit-Position: refs/heads/master@{#443855} Committed: https://chromium.googlesource.com/chromium/src/+/6d266375ae1ebcd12933e946a1ce455fbec9b7b6

Patch Set 1 #

Messages

Total messages: 13 (8 generated)
Shuhei Takahashi
hidehiko: PTAL
5 months, 1 week ago (2017-01-16 06:55:07 UTC) #4
hidehiko
LGTM!
5 months, 1 week ago (2017-01-16 06:59:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2638713002/1
5 months, 1 week ago (2017-01-16 07:39:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6d266375ae1ebcd12933e946a1ce455fbec9b7b6
5 months, 1 week ago (2017-01-16 07:43:17 UTC) #12
pkalinnikov
5 months, 1 week ago (2017-01-16 14:10:45 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2635943002/ by pkalinnikov@chromium.org.

The reason for reverting is: ArcSessionManagerTest.ConsumerAccount and 3 more
ArcSessionManagerTest.* tests are failing on "Linux Chromium OS ASan LSan Tests
(1)" builder..
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld cb946e318