Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2635633002: [Offline Pages] Add explicit DependsOn clause to request coordinator factory (Closed)

Created:
3 years, 11 months ago by chili
Modified:
3 years, 11 months ago
CC:
chromium-reviews, romax+watch_chromium.org, fgorski+watch_chromium.org, dewittj+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Add explicit DependsOn clause to request coordinator factory and delete a flaky test BUG=679844 Review-Url: https://codereview.chromium.org/2635633002 Cr-Commit-Position: refs/heads/master@{#444285} Committed: https://chromium.googlesource.com/chromium/src/+/f109c99563e6efe928faee2ba68402f1a3cc06f3

Patch Set 1 #

Patch Set 2 : remove from build and rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -49 lines) Patch
M chrome/browser/android/offline_pages/request_coordinator_factory.cc View 1 chunk +3 lines, -1 line 0 comments Download
D chrome/browser/android/offline_pages/request_coordinator_factory_unittest.cc View 1 chunk +0 lines, -47 lines 0 comments Download
M chrome/test/BUILD.gn View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (11 generated)
chili
I've updated some steps taken in the original bug, if you're curious what has already ...
3 years, 11 months ago (2017-01-14 02:03:03 UTC) #2
Pete Williamson
lgtm
3 years, 11 months ago (2017-01-17 18:29:37 UTC) #3
fgorski
lgtm
3 years, 11 months ago (2017-01-17 21:40:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635633002/1
3 years, 11 months ago (2017-01-17 22:41:12 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/194971) android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-17 23:03:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635633002/20001
3 years, 11 months ago (2017-01-18 05:31:40 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-18 05:37:06 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f109c99563e6efe928faee2ba684...

Powered by Google App Engine
This is Rietveld 408576698