Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: chrome/browser/android/offline_pages/request_coordinator_factory_unittest.cc

Issue 2635633002: [Offline Pages] Add explicit DependsOn clause to request coordinator factory (Closed)
Patch Set: remove from build and rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/offline_pages/request_coordinator_factory.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/offline_pages/request_coordinator_factory_unittest.cc
diff --git a/chrome/browser/android/offline_pages/request_coordinator_factory_unittest.cc b/chrome/browser/android/offline_pages/request_coordinator_factory_unittest.cc
deleted file mode 100644
index 97766c452a0d3f9b86487e35977f268375c54c65..0000000000000000000000000000000000000000
--- a/chrome/browser/android/offline_pages/request_coordinator_factory_unittest.cc
+++ /dev/null
@@ -1,47 +0,0 @@
-// Copyright 2016 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
-
-#include "chrome/test/base/chrome_render_view_host_test_harness.h"
-#include "components/offline_pages/core/background/request_coordinator.h"
-#include "content/public/browser/browser_thread.h"
-#include "testing/gtest/include/gtest/gtest.h"
-
-namespace offline_pages {
-
-class RequestCoordinatorFactoryTest : public ChromeRenderViewHostTestHarness {
- public:
- RequestCoordinatorFactoryTest();
- ~RequestCoordinatorFactoryTest() override;
-
- void FlushBlockingPool();
-};
-
-RequestCoordinatorFactoryTest::RequestCoordinatorFactoryTest() {}
-
-RequestCoordinatorFactoryTest::~RequestCoordinatorFactoryTest() {}
-
-void RequestCoordinatorFactoryTest::FlushBlockingPool() {
- content::BrowserThread::GetBlockingPool()->FlushForTesting();
-}
-
-// Flaky on android_n5x_swarming_rel. https://crbug.com/679844
-TEST_F(RequestCoordinatorFactoryTest, DISABLED_BuildRequestCoordinator) {
- RequestCoordinatorFactory* factory = RequestCoordinatorFactory::GetInstance();
- EXPECT_NE(nullptr, factory);
- RequestCoordinator* coordinator1 =
- factory->GetForBrowserContext(browser_context());
- // We should actually get a coordinator.
- EXPECT_NE(nullptr, coordinator1);
-
- RequestCoordinator* coordinator2 =
- factory->GetForBrowserContext(browser_context());
- // Calling twice gives us the same coordinator.
- EXPECT_EQ(coordinator1, coordinator2);
-
- FlushBlockingPool();
-}
-
-} // namespace offline_pages
« no previous file with comments | « chrome/browser/android/offline_pages/request_coordinator_factory.cc ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698