Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(897)

Issue 2635613002: Replace deprecated calls to GetMetadata in Physical Web omnibox provider (Closed)

Created:
3 years, 11 months ago by mattreynolds
Modified:
3 years, 11 months ago
Reviewers:
Mark P
CC:
chromium-reviews, jdonnelly+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace deprecated calls to GetMetadata in Physical Web omnibox provider Use GetMetadataList instead of GetMetadata, which is now deprecated. BUG=667722 Review-Url: https://codereview.chromium.org/2635613002 Cr-Commit-Position: refs/heads/master@{#444604} Committed: https://chromium.googlesource.com/chromium/src/+/1d38d1162ada6155fa1710e06cc41d3875d32739

Patch Set 1 #

Patch Set 2 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -83 lines) Patch
M components/omnibox/browser/physical_web_node.h View 1 chunk +3 lines, -3 lines 0 comments Download
M components/omnibox/browser/physical_web_node.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M components/omnibox/browser/physical_web_provider.h View 3 chunks +7 lines, -4 lines 0 comments Download
M components/omnibox/browser/physical_web_provider.cc View 5 chunks +11 lines, -24 lines 0 comments Download
M components/omnibox/browser/physical_web_provider_unittest.cc View 1 10 chunks +32 lines, -42 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mattreynolds
Hi Mark, PTAL
3 years, 11 months ago (2017-01-17 22:06:35 UTC) #2
Mark P
lgtm
3 years, 11 months ago (2017-01-17 23:33:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635613002/1
3 years, 11 months ago (2017-01-18 19:13:09 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-clang/builds/23196) ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, ...
3 years, 11 months ago (2017-01-18 19:19:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2635613002/20001
3 years, 11 months ago (2017-01-19 01:11:18 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 02:46:03 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/1d38d1162ada6155fa1710e06cc4...

Powered by Google App Engine
This is Rietveld 408576698