Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: components/omnibox/browser/physical_web_provider.h

Issue 2635613002: Replace deprecated calls to GetMetadata in Physical Web omnibox provider (Closed)
Patch Set: fix tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/omnibox/browser/physical_web_provider.h
diff --git a/components/omnibox/browser/physical_web_provider.h b/components/omnibox/browser/physical_web_provider.h
index a689a704b04772e40a5f1261b59a20ed56b1b8c8..cab09c5c98296ab58b1616f2d42abdacdf80101c 100644
--- a/components/omnibox/browser/physical_web_provider.h
+++ b/components/omnibox/browser/physical_web_provider.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_
#define COMPONENTS_OMNIBOX_BROWSER_PHYSICAL_WEB_PROVIDER_H_
+#include <vector>
+
#include "base/macros.h"
#include "components/bookmarks/browser/titled_url_match.h"
#include "components/omnibox/browser/autocomplete_input.h"
@@ -13,8 +15,9 @@
class AutocompleteProviderClient;
class HistoryURLProvider;
-namespace base {
-class ListValue;
+namespace physical_web {
+struct Metadata;
+using MetadataList = std::vector<Metadata>;
}
class PhysicalWebProvider : public AutocompleteProvider {
@@ -50,14 +53,14 @@ class PhysicalWebProvider : public AutocompleteProvider {
// of matches allowed. If the total number of nearby URLs exceeds this limit,
// one match is used for an overflow item.
void ConstructZeroSuggestMatches(
- std::unique_ptr<base::ListValue> metadata_list);
+ std::unique_ptr<physical_web::MetadataList> metadata_list);
// When the user has entered text into the omnibox (i.e., the Query Suggest
// case), calling this method adds a separate match item to |matches_| for
// each nearby URL in |metadata_list| that matches all of the query terms in
// |input|, up to the maximum number of matches allowed.
void ConstructQuerySuggestMatches(
- std::unique_ptr<base::ListValue> metadata_list,
+ std::unique_ptr<physical_web::MetadataList> metadata_list,
const AutocompleteInput& input);
// Adds an overflow match item to |matches_| with a relevance score equal to
« no previous file with comments | « components/omnibox/browser/physical_web_node.cc ('k') | components/omnibox/browser/physical_web_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698