Cleanup .gitignore rules for third_party directory

Do not ignore inspector_protocol and binutils directories

third_party/inspector_protocol is tracked in git and ignoring it causes
problems if the tree is copied to another git repository (e.g. Node.js)
Similarly, third_party/binutils has some files checked in. This adds a
.gitignore file in this directory (same as Chromium).

R=franzih@chromium.org,ofrobots@google.com,machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2635483002
Cr-Commit-Position: refs/heads/master@{#42373}
Committed: https://chromium.googlesource.com/v8/v8/+/9c10cb023097d217b76137cbffb7a7a9a6b5e70e

[Michael Achenbach, 2017-01-16 07:43:04]

lgtm if comment addressed:

https://codereview.chromium.org/2635483002/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2635483002/diff/1/.gitignore#newcode64
.gitignore:64: /third_party/*
This wouldn't be correct, because binutils is also checked in. How about you
reduce lines 64-69 to:

/third_party/*
!/third_party/binutils
!/third_party/inspector_protocol

[targos, 2017-01-16 10:00:31]

Updated to remove superfluous lines

https://codereview.chromium.org/2635483002/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2635483002/diff/1/.gitignore#newcode64
.gitignore:64: /third_party/*
On 2017/01/16 at 07:43:04, Michael Achenbach wrote:
> This wouldn't be correct, because binutils is also checked in. How about you
reduce lines 64-69 to:
> 
> /third_party/*
> !/third_party/binutils
> !/third_party/inspector_protocol

binutils only contains a download script and the binutils.tar.bz2.sha1 files. I
guess the rest should stay ignored.

[Michael Achenbach, 2017-01-16 10:48:56]

https://codereview.chromium.org/2635483002/diff/1/.gitignore
File .gitignore (right):

https://codereview.chromium.org/2635483002/diff/1/.gitignore#newcode64
.gitignore:64: /third_party/*
On 2017/01/16 10:00:31, targos wrote:
> On 2017/01/16 at 07:43:04, Michael Achenbach wrote:
> > This wouldn't be correct, because binutils is also checked in. How about you
> reduce lines 64-69 to:
> > 
> > /third_party/*
> > !/third_party/binutils
> > !/third_party/inspector_protocol
> 
> binutils only contains a download script and the binutils.tar.bz2.sha1 files.
I
> guess the rest should stay ignored.

Not sure if I understand. Currently the only two directories with files checked
in are:
https://chromium.googlesource.com/v8/v8/+/c4a35ed7e831448e1fd2a2ca1f79d5fefae...

So, all directories except these two should be ignored. /third_party/* ignores
all directories and files matching /third_party/*, so also
/third_party/binutils, which therefore (so I think) should have an exception
!/third_party/binutils.

There are also generated/downloaded files withing binutils that probably should
have their own ignore entries, which we lack. Chromium has one:
https://chromium.googlesource.com/chromium/src/+/lkgr/third_party/binutils/.g...

[targos, 2017-01-16 12:41:21]

Description was changed from

==========
Do not ignore inspector_protocol directory

third_party/inspector_protocol is tracked in git and ignoring it causes
problems if the tree is copied to another git repository (e.g. Node.js)

R=franzih@chromium.org,ofrobots@google.com,machenbach@chromium.org
BUG=
==========

to

==========
Do not ignore inspector_protocol and binutils directories

third_party/inspector_protocol is tracked in git and ignoring it causes
problems if the tree is copied to another git repository (e.g. Node.js)
Similarly, third_party/binutils has some files checked in. This adds a
.gitignore file in this directory (same as Chromium).

R=franzih@chromium.org,ofrobots@google.com,machenbach@chromium.org
BUG=
==========

[targos, 2017-01-16 12:42:24]

Alright, thanks. I unignored binutils and added a copy of the .gitignore from
Chromium.

[Michael Achenbach, 2017-01-16 12:49:10]

thanks, lgtm

[targos, 2017-01-16 12:54:38]

The CQ bit was checked by mic.besace@gmail.com

[commit-bot: I haz the power, 2017-01-16 12:54:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 13:22:00]

CQ is committing da patch.

Bot data: {"patchset_id": 30001, "attempt_start_ts": 1484571278910300,
"parent_rev": "ef555d08a976e5f2d22fb76d6538d53a90d052f2", "commit_rev":
"9c10cb023097d217b76137cbffb7a7a9a6b5e70e"}

[commit-bot: I haz the power, 2017-01-16 13:22:03]

Description was changed from

==========
Do not ignore inspector_protocol and binutils directories

third_party/inspector_protocol is tracked in git and ignoring it causes
problems if the tree is copied to another git repository (e.g. Node.js)
Similarly, third_party/binutils has some files checked in. This adds a
.gitignore file in this directory (same as Chromium).

R=franzih@chromium.org,ofrobots@google.com,machenbach@chromium.org
BUG=
==========

to

==========
Do not ignore inspector_protocol and binutils directories

third_party/inspector_protocol is tracked in git and ignoring it causes
problems if the tree is copied to another git repository (e.g. Node.js)
Similarly, third_party/binutils has some files checked in. This adds a
.gitignore file in this directory (same as Chromium).

R=franzih@chromium.org,ofrobots@google.com,machenbach@chromium.org
BUG=

Review-Url: https://codereview.chromium.org/2635483002
Cr-Commit-Position: refs/heads/master@{#42373}
Committed:
https://chromium.googlesource.com/v8/v8/+/9c10cb023097d217b76137cbffb7a7a9a6b...
==========

[commit-bot: I haz the power, 2017-01-16 13:22:04]

Committed patchset #3 (id:30001) as
https://chromium.googlesource.com/v8/v8/+/9c10cb023097d217b76137cbffb7a7a9a6b...