.gitignore - Issue 2635483002: Cleanup .gitignore rules for third_party directory

Side by Side Diff: .gitignore

Issue 2635483002: Cleanup .gitignore rules for third_party directory (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 *.a	1 *.a

2 *.exe	2 *.exe

3 *.idb	3 *.idb

4 *.lib	4 *.lib

5 *.log	5 *.log

6 *.map	6 *.map

7 *.mk	7 *.mk

8 *.ncb	8 *.ncb

9 *.pdb	9 *.pdb

10 *.pyc	10 *.pyc

(...skipping 43 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
54 /test/mozilla/data	54 /test/mozilla/data

55 /test/promises-aplus/promises-tests	55 /test/promises-aplus/promises-tests

56 /test/promises-aplus/promises-tests.tar.gz	56 /test/promises-aplus/promises-tests.tar.gz

57 /test/promises-aplus/sinon	57 /test/promises-aplus/sinon

58 /test/simdjs/data	58 /test/simdjs/data

59 /test/test262/data	59 /test/test262/data

60 /test/test262/data.tar	60 /test/test262/data.tar

61 /test/test262/harness	61 /test/test262/harness

62 /testing/gmock	62 /testing/gmock

63 /testing/gtest	63 /testing/gtest

64 /third_party	64 /third_party/*
	Michael Achenbach 2017/01/16 07:43:04 This wouldn't be correct, because binutils is also This wouldn't be correct, because binutils is also checked in. How about you reduce lines 64-69 to: /third_party/* !/third_party/binutils !/third_party/inspector_protocol targos 2017/01/16 10:00:31 binutils only contains a download script and the b Show quoted text On 2017/01/16 at 07:43:04, Michael Achenbach wrote: > This wouldn't be correct, because binutils is also checked in. How about you reduce lines 64-69 to: > > /third_party/* > !/third_party/binutils > !/third_party/inspector_protocol binutils only contains a download script and the binutils.tar.bz2.sha1 files. I guess the rest should stay ignored. Michael Achenbach 2017/01/16 10:48:56 Not sure if I understand. Currently the only two d Show quoted text On 2017/01/16 10:00:31, targos wrote: > On 2017/01/16 at 07:43:04, Michael Achenbach wrote: > > This wouldn't be correct, because binutils is also checked in. How about you > reduce lines 64-69 to: > > > > /third_party/* > > !/third_party/binutils > > !/third_party/inspector_protocol > > binutils only contains a download script and the binutils.tar.bz2.sha1 files. I > guess the rest should stay ignored. Not sure if I understand. Currently the only two directories with files checked in are: https://chromium.googlesource.com/v8/v8/+/c4a35ed7e831448e1fd2a2ca1f79d5fefae... So, all directories except these two should be ignored. /third_party/* ignores all directories and files matching /third_party/*, so also /third_party/binutils, which therefore (so I think) should have an exception !/third_party/binutils. There are also generated/downloaded files withing binutils that probably should have their own ignore entries, which we lack. Chromium has one: https://chromium.googlesource.com/chromium/src/+/lkgr/third_party/binutils/.g...
65 /third_party/android_tools	65 /third_party/android_tools

66 /third_party/cygwin	66 /third_party/cygwin

67 /third_party/icu	67 /third_party/icu

68 /third_party/instrumented_libraries	68 /third_party/instrumented_libraries

69 /third_party/inspector_protocol	69 !/third_party/inspector_protocol

70 /third_party/jinja2	70 /third_party/jinja2

71 /third_party/llvm	71 /third_party/llvm

72 /third_party/llvm-build	72 /third_party/llvm-build

73 /third_party/markupsafe	73 /third_party/markupsafe

74 /tools/clang	74 /tools/clang

75 /tools/gcmole/gcmole-tools	75 /tools/gcmole/gcmole-tools

76 /tools/gcmole/gcmole-tools.tar.gz	76 /tools/gcmole/gcmole-tools.tar.gz

77 /tools/gyp	77 /tools/gyp

78 /tools/jsfunfuzz/jsfunfuzz	78 /tools/jsfunfuzz/jsfunfuzz

79 /tools/jsfunfuzz/jsfunfuzz.tar.gz	79 /tools/jsfunfuzz/jsfunfuzz.tar.gz

(...skipping 17 matching lines...) Expand all Loading...
97 GPATH	97 GPATH

98 tags	98 tags

99 gtags.files	99 gtags.files

100 turbo*.cfg	100 turbo*.cfg

101 turbo*.dot	101 turbo*.dot

102 turbo*.json	102 turbo*.json

103 v8.ignition_dispatches_table.json	103 v8.ignition_dispatches_table.json

104 /test/fuzzer/wasm.tar.gz	104 /test/fuzzer/wasm.tar.gz

105 /test/fuzzer/wasm_asmjs.tar.gz	105 /test/fuzzer/wasm_asmjs.tar.gz

106 /src/inspector/build/closure-compiler.tar.gz	106 /src/inspector/build/closure-compiler.tar.gz

107 /src/inspector/build/closure-compiler	107 /src/inspector/build/closure-compiler

OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »