Changed EBoxSizing to an enum class and renamed its members

Changed EBoxSizing to an enum class and renamed its members

Changed EBoxSizing to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EBoxSizing to be used by generated
fields in ComputedStyleBase.

BUG=628043
Review-Url: https://codereview.chromium.org/2625553005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2635143002
Cr-Commit-Position: refs/heads/master@{#444278}
Committed: https://chromium.googlesource.com/chromium/src/+/dabe54f6a65efa95a6587d88c2745fac3188c80c

[sashab, 2017-01-17 03:57:10]

Description was changed from

==========
Changed EBoxSizing to an enum class and renamed its members

Changed EBoxSizing to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EBoxSizing to be used by generated
fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2625553005
==========

to

==========
Changed EBoxSizing to an enum class and renamed its members

Changed EBoxSizing to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EBoxSizing to be used by generated
fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2625553005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[sashab, 2017-01-17 03:57:13]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 03:57:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sashab, 2017-01-17 04:00:31]

sashab@chromium.org changed reviewers:
+ napper@chromium.org

[napper, 2017-01-17 04:04:56]

https://codereview.chromium.org/2635143002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp
(right):

https://codereview.chromium.org/2635143002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/ComputedStyleCSSValueMapping.cpp:1085: return
box->style()->boxSizing() == EBoxSizing::BorderBox
Did you mean to also add the 'k' prefix as per your CL description?

[commit-bot: I haz the power, 2017-01-17 04:07:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 04:07:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[sashab, 2017-01-18 01:44:54]

The CQ bit was checked by sashab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 01:45:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 03:45:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 03:46:00]

Dry run: Try jobs failed on following builders:
  linux_layout_tests_slimming_paint_v2 on master.tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)

[sashab, 2017-01-18 04:08:54]

Haha thanks for that napper, just as well I wrote it in the CL description! ;)

Ptal now

[napper, 2017-01-18 04:50:45]

lgtm

[sashab, 2017-01-18 04:56:17]

The CQ bit was checked by sashab@chromium.org

[commit-bot: I haz the power, 2017-01-18 04:56:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 05:00:03]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484715377280720,
"parent_rev": "f19152f5dc5662089835b10bf7d98c7bcbc42efd", "commit_rev":
"dabe54f6a65efa95a6587d88c2745fac3188c80c"}

[commit-bot: I haz the power, 2017-01-18 05:00:46]

Description was changed from

==========
Changed EBoxSizing to an enum class and renamed its members

Changed EBoxSizing to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EBoxSizing to be used by generated
fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2625553005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Changed EBoxSizing to an enum class and renamed its members

Changed EBoxSizing to an enum class and gave it an unsigned underlying
type. Also renamed its members to match the CSS keywords they
represent, and added the 'k' prefix in line with the Blink rename to
match Chromium style.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield (it would be done in this
patch, except a presubmit warning already exists that prevents that. The
presubmit warning needs to be updated before that change can occur.)

This is also pre-work to allow EBoxSizing to be used by generated
fields in ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2625553005
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2635143002
Cr-Commit-Position: refs/heads/master@{#444278}
Committed:
https://chromium.googlesource.com/chromium/src/+/dabe54f6a65efa95a6587d88c274...
==========

[commit-bot: I haz the power, 2017-01-18 05:00:47]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/dabe54f6a65efa95a6587d88c274...