chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java - Issue 2635123002: Fix VrShell resizing incorrectly by setting the CompositorViewHolder to a fixed size when in VR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java

Issue 2635123002: Fix VrShell resizing incorrectly by setting the CompositorViewHolder to a fixed size when in VR. (Closed)

Patch Set: Set CompositorViewHolder size instead Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java

index 067749b5ba56c11a87ff12b8b1a22f3270a552b9..7c4750deab9353c081108d20e52ffb2a4b81b665 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java

@@ -9,6 +9,7 @@ import android.os.StrictMode;

import org.chromium.base.Log;

import org.chromium.base.annotations.UsedByReflection;

+import org.chromium.chrome.browser.compositor.CompositorViewHolder;

/**

* Builder class to create all VR related classes. These VR classes are behind the same build time

@@ -38,10 +39,10 @@ public class VrClassesBuilderImpl implements VrClassesBuilder {

}

@Override

- public VrShell createVrShell() {

+ public VrShell createVrShell(CompositorViewHolder compositorViewHolder) {

StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();

try {

- return new VrShellImpl(mActivity);

+ return new VrShellImpl(mActivity, compositorViewHolder);

} catch (Exception ex) {

Log.e(TAG, "Unable to instantiate VrShellImpl", ex);

return null;