chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java - Issue 2635123002: Fix VrShell resizing incorrectly by setting the CompositorViewHolder to a fixed size when in VR.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

Issue 2635123002: Fix VrShell resizing incorrectly by setting the CompositorViewHolder to a fixed size when in VR. (Closed)

Patch Set: Set CompositorViewHolder size instead Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

index 7a36bd41bc71ee8959c4815b44dff57685307aaf..586bf5960de4c692bab9e559d46fc9796d68e379 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java

@@ -139,7 +139,7 @@ public class VrShellDelegate {

@Override

public void onLoadProgressChanged(Tab tab, int progress) {

if (!mInVr) return;

- mVrShell.onLoadProgressChanged((double) progress / 100.0);

+ mVrShell.onLoadProgressChanged(progress / 100.0);

}

};

}

@@ -508,7 +508,7 @@ public class VrShellDelegate {

private boolean createVrShell() {

if (mVrClassesBuilder == null) return false;

- mVrShell = mVrClassesBuilder.createVrShell();

+ mVrShell = mVrClassesBuilder.createVrShell(mActivity.getCompositorViewHolder());

return mVrShell != null;

}