Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java

Issue 2635123002: Fix VrShell resizing incorrectly by setting the CompositorViewHolder to a fixed size when in VR. (Closed)
Patch Set: Set CompositorViewHolder size instead Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java
index a2c4de721f9c9578fd99c4c1a5fa73448ecdd9eb..93989d47b33e98ea3941abb072f2df65e31f33c2 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilder.java
@@ -4,6 +4,8 @@
package org.chromium.chrome.browser.vr_shell;
+import org.chromium.chrome.browser.compositor.CompositorViewHolder;
+
/**
* Abstracts away the VrClassesBuilderImpl class, which may or may not be present at runtime
* depending on compile flags.
@@ -17,7 +19,7 @@ public interface VrClassesBuilder {
/**
* Creates a VrShellImpl instance.
*/
- public VrShell createVrShell();
+ public VrShell createVrShell(CompositorViewHolder compositorViewHolder);
/**
* Creates a VrDaydreamApImpl instance.
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrClassesBuilderImpl.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698