Avoid infinite recursion in StringImpl::asciiForDebugging

Avoid infinite recursion in StringImpl::asciiForDebugging

If any of the DCHECKs are hit in ref/deref/hasOneRef, then calling
substring() on the underlying impl can also trigger DCHECKs, causing
infinite recursion.

BUG=681581
Review-Url: https://codereview.chromium.org/2635033002
Cr-Commit-Position: refs/heads/master@{#444035}
Committed: https://chromium.googlesource.com/chromium/src/+/965f6c6f71cd704f638caf664c591986a5d8df53

[Charlie Harrison, 2017-01-16 17:08:41]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 17:09:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-01-16 17:12:13]

csharrison@chromium.org changed reviewers:
+ esprehn@chromium.org

[Charlie Harrison, 2017-01-16 17:12:13]

esprehn: We made a mistake in avoiding copies here :)

[commit-bot: I haz the power, 2017-01-16 18:30:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 18:30:06]

Dry run: This issue passed the CQ dry run.

[esprehn, 2017-01-17 10:50:50]

lgtm

[Charlie Harrison, 2017-01-17 12:59:49]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-01-17 13:00:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 13:04:21]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484657989136270, "parent_rev":
"9b6709fa7db12ad73846449fb64f07ea9b880ce0", "commit_rev":
"965f6c6f71cd704f638caf664c591986a5d8df53"}

[commit-bot: I haz the power, 2017-01-17 13:04:48]

Description was changed from

==========
Avoid infinite recursion in StringImpl::asciiForDebugging

If any of the DCHECKs are hit in ref/deref/hasOneRef, then calling
substring() on the underlying impl can also trigger DCHECKs, causing
infinite recursion.

BUG=681581
==========

to

==========
Avoid infinite recursion in StringImpl::asciiForDebugging

If any of the DCHECKs are hit in ref/deref/hasOneRef, then calling
substring() on the underlying impl can also trigger DCHECKs, causing
infinite recursion.

BUG=681581

Review-Url: https://codereview.chromium.org/2635033002
Cr-Commit-Position: refs/heads/master@{#444035}
Committed:
https://chromium.googlesource.com/chromium/src/+/965f6c6f71cd704f638caf664c59...
==========

[commit-bot: I haz the power, 2017-01-17 13:04:49]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/965f6c6f71cd704f638caf664c59...