third_party/WebKit/Source/wtf/text/StringImpl.cpp - Issue 2635033002: Avoid infinite recursion in StringImpl::asciiForDebugging

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.cpp

Issue 2635033002: Avoid infinite recursion in StringImpl::asciiForDebugging (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImpl.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.cpp b/third_party/WebKit/Source/wtf/text/StringImpl.cpp

index f8b6b7b033bb9be1e02e8ffbe480421656638a98..6654e3040fbb556d50ee42fb0180e10a2a2e184a 100644

--- a/third_party/WebKit/Source/wtf/text/StringImpl.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringImpl.cpp

@@ -335,7 +335,7 @@ bool StringImpl::isSafeToSendToAnotherThread() const {

#if DCHECK_IS_ON()

std::string StringImpl::asciiForDebugging() const {

- CString ascii = String(substring(0, 128)).ascii();

+ CString ascii = String(isolatedCopy()->substring(0, 128)).ascii();

return std::string(ascii.data(), ascii.length());

}

#endif

« no previous file with comments | « no previous file | no next file » | no next file with comments »