[foozzie] Stop using extra metadata files.

[foozzie] Stop using extra metadata files.

Continuation of:
https://codereview.chromium.org/2620343005/

This removes usage of metadata files entirely. Instead we extract
the instrumentation about source files from the test cases.

This also adds extra output of the original source file in the
detailed failure text for easier debugging. The hashes alone
made it hard to reason.

BUG=chromium:673246
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org

Review-Url: https://codereview.chromium.org/2634743004
Cr-Commit-Position: refs/heads/master@{#42371}
Committed: https://chromium.googlesource.com/v8/v8/+/69465f73f88b0f9dd5b89ae9910881e5d20b5f86

[Michael Achenbach, 2017-01-16 10:18:43]

Description was changed from

==========
[foozzie] Stop using extra metadata files.

BUG=
==========

to

==========
[foozzie] Stop using extra metadata files.

Continuation of:
https://codereview.chromium.org/2620343005/

This removes usage of metadata files entirely. Instead we extract
the instrumentation about source files from the test cases.

This also adds extra output of the original source file in the
detailed failure text for easier debugging. The hashes alone
made it hard to reason.

BUG=chromium:673246
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org
==========

[Michael Achenbach, 2017-01-16 10:18:43]

machenbach@chromium.org changed reviewers:
+ mbarbella@chromium.org, tandrii@chromium.org

[Michael Achenbach, 2017-01-16 10:21:05]

machenbach@chromium.org changed reviewers:
+ mmoroz@chromium.org

[Michael Achenbach, 2017-01-16 10:21:06]

PTAL

[mmoroz, 2017-01-16 12:39:58]

LGTM

https://codereview.chromium.org/2634743004/diff/20001/tools/foozzie/v8_suppre...
File tools/foozzie/v8_suppressions.py (right):

https://codereview.chromium.org/2634743004/diff/20001/tools/foozzie/v8_suppre...
tools/foozzie/v8_suppressions.py:191: 'none' if no such output existed.
nit: maybe it makes sense to put 'none' string into a constant?

[Michael Achenbach, 2017-01-16 12:58:41]

https://codereview.chromium.org/2634743004/diff/20001/tools/foozzie/v8_suppre...
File tools/foozzie/v8_suppressions.py (right):

https://codereview.chromium.org/2634743004/diff/20001/tools/foozzie/v8_suppre...
tools/foozzie/v8_suppressions.py:191: 'none' if no such output existed.
On 2017/01/16 12:39:58, mmoroz wrote:
> nit: maybe it makes sense to put 'none' string into a constant?

Done.

[Michael Achenbach, 2017-01-16 12:59:09]

The CQ bit was checked by machenbach@chromium.org

[Michael Achenbach, 2017-01-16 12:59:09]

The patchset sent to the CQ was uploaded after l-g-t-m from mmoroz@chromium.org
Link to the patchset: https://codereview.chromium.org/2634743004/#ps40001
(title: "Review")

[commit-bot: I haz the power, 2017-01-16 12:59:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 13:00:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484571549062740,
"parent_rev": "22abb8b1235d22afd8cac87682188d1321160b53", "commit_rev":
"69465f73f88b0f9dd5b89ae9910881e5d20b5f86"}

[commit-bot: I haz the power, 2017-01-16 13:00:54]

Description was changed from

==========
[foozzie] Stop using extra metadata files.

Continuation of:
https://codereview.chromium.org/2620343005/

This removes usage of metadata files entirely. Instead we extract
the instrumentation about source files from the test cases.

This also adds extra output of the original source file in the
detailed failure text for easier debugging. The hashes alone
made it hard to reason.

BUG=chromium:673246
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org
==========

to

==========
[foozzie] Stop using extra metadata files.

Continuation of:
https://codereview.chromium.org/2620343005/

This removes usage of metadata files entirely. Instead we extract
the instrumentation about source files from the test cases.

This also adds extra output of the original source file in the
detailed failure text for easier debugging. The hashes alone
made it hard to reason.

BUG=chromium:673246
NOTRY=true
TBR=tandrii@chromium.org,mbarbella@chromium.org

Review-Url: https://codereview.chromium.org/2634743004
Cr-Commit-Position: refs/heads/master@{#42371}
Committed:
https://chromium.googlesource.com/v8/v8/+/69465f73f88b0f9dd5b89ae9910881e5d20...
==========

[commit-bot: I haz the power, 2017-01-16 13:00:55]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/69465f73f88b0f9dd5b89ae9910881e5d20...

[tandrii(chromium), 2017-01-16 13:39:40]

https://codereview.chromium.org/2634743004/diff/40001/tools/foozzie/v8_suppre...
File tools/foozzie/v8_suppressions.py (right):

https://codereview.chromium.org/2634743004/diff/40001/tools/foozzie/v8_suppre...
tools/foozzie/v8_suppressions.py:186: """Returns a tuple (difference, source,
source_key).
the source -> source_key is deterministic here.
how about just return source here, and there having a func to convert source =>
source_key in another file where source_key is necessary, which would be as
short as:
 hashlib.sha(source).digest()[:3] if source else 'none'

wdyt?

[Michael Achenbach, 2017-01-16 13:46:47]

https://codereview.chromium.org/2634743004/diff/40001/tools/foozzie/v8_suppre...
File tools/foozzie/v8_suppressions.py (right):

https://codereview.chromium.org/2634743004/diff/40001/tools/foozzie/v8_suppre...
tools/foozzie/v8_suppressions.py:186: """Returns a tuple (difference, source,
source_key).
On 2017/01/16 13:39:40, tandrii(chromium) wrote:
> the source -> source_key is deterministic here.
> how about just return source here, and there having a func to convert source
=>
> source_key in another file where source_key is necessary, which would be as
> short as:
>  hashlib.sha(source).digest()[:3] if source else 'none'
> 
> wdyt?

Sg, will prepare a fix.