Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Unified Diff: tools/foozzie/v8_foozzie_test.py

Issue 2634743004: [foozzie] Stop using extra metadata files. (Closed)
Patch Set: Review Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/foozzie/v8_foozzie_test.py
diff --git a/tools/foozzie/v8_foozzie_test.py b/tools/foozzie/v8_foozzie_test.py
index b50702a57e2f4526a583e64407814df1fa1b56a2..13b7e6b6a4331fce4554db4e757886eb04bf6c58 100644
--- a/tools/foozzie/v8_foozzie_test.py
+++ b/tools/foozzie/v8_foozzie_test.py
@@ -21,12 +21,12 @@ class UnitTest(unittest.TestCase):
'x64', 'fullcode', 'x64', 'default')
one = ''
two = ''
- diff = None, 'none'
+ diff = None, 'none', 'none'
self.assertEquals(diff, suppress.diff(one, two))
one = 'a \n b\nc();'
two = 'a \n b\nc();'
- diff = None, 'none'
+ diff = None, 'none', 'none'
self.assertEquals(diff, suppress.diff(one, two))
# Ignore line before caret, caret position, stack trace char numbers
@@ -49,7 +49,7 @@ stack line :2: foo
Validation of asm.js module failed: baz
undefined
"""
- diff = None, 'none'
+ diff = None, 'none', 'none'
self.assertEquals(diff, suppress.diff(one, two))
one = """
@@ -59,7 +59,7 @@ Extra line
two = """
Still equal
"""
- diff = '- Extra line', 'none'
+ diff = '- Extra line', 'none', 'none'
self.assertEquals(diff, suppress.diff(one, two))
one = """
@@ -69,7 +69,7 @@ Still equal
Still equal
Extra line
"""
- diff = '+ Extra line', 'none'
+ diff = '+ Extra line', 'none', 'none'
self.assertEquals(diff, suppress.diff(one, two))
one = """
@@ -81,7 +81,7 @@ undefined
otherfile.js: TypeError: undefined is not a constructor
"""
diff = """- somefile.js: TypeError: undefined is not a constructor
-+ otherfile.js: TypeError: undefined is not a constructor""", 'none'
++ otherfile.js: TypeError: undefined is not a constructor""", 'none', 'none'
self.assertEquals(diff, suppress.diff(one, two))

Powered by Google App Engine
This is Rietveld 408576698