Remove PageVisibilityObserver contextDestroyed() notifications.

Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.

R=haraken
BUG=610176
Review-Url: https://codereview.chromium.org/2634713002
Cr-Commit-Position: refs/heads/master@{#443816}
Committed: https://chromium.googlesource.com/chromium/src/+/65dfcc360fbc88445210a0e99aae7af6a8a5ac67

[sof, 2017-01-14 21:34:18]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 21:34:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 23:08:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 23:08:37]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[sof, 2017-01-15 12:04:05]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 12:04:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sof, 2017-01-15 12:47:00]

The CQ bit was checked by sigbjornf@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 12:47:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[haraken, 2017-01-15 13:03:22]

LGTM

[commit-bot: I haz the power, 2017-01-15 14:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-15 14:31:52]

Dry run: This issue passed the CQ dry run.

[sof, 2017-01-15 15:19:13]

Description was changed from

==========
Simplify contextDestroyed()

R=
BUG=
==========

to

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.


R=
BUG=
==========

[sof, 2017-01-15 15:20:11]

Description was changed from

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.


R=
BUG=
==========

to

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.


R=haraken
BUG=610176
==========

[sof, 2017-01-15 15:20:37]

Description was changed from

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.


R=haraken
BUG=610176
==========

to

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.

R=haraken
BUG=610176
==========

[sof, 2017-01-15 15:30:43]

The CQ bit was checked by sigbjornf@opera.com

[commit-bot: I haz the power, 2017-01-15 15:30:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-15 15:34:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484494243727520,
"parent_rev": "679dbea4a9aefcf6225de820f10e0d562995bdb1", "commit_rev":
"65dfcc360fbc88445210a0e99aae7af6a8a5ac67"}

[commit-bot: I haz the power, 2017-01-15 15:35:22]

Description was changed from

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.

R=haraken
BUG=610176
==========

to

==========
Remove PageVisibilityObserver contextDestroyed() notifications.

PageVisibilityObserver allows a Page's lifetime states to be
observed, but none of the observers need to be notified of Page
destruction.

Adjust LifecycleNotifier<>::notifyContextDestroyed(), having it
call its corresponding LifecycleObserver's  contextDestroyed()
notification method if the observer implements it, but not require
that it does implement contextDestroyed(). With that in place,
only have the lifecycle observers that need a contextDestroyed()
notification (all but PageVisibilityObserver) declare it.

This allows the removal of all the empty 
PageVisibilityObserver::contextDestroyed() overrides.

R=haraken
BUG=610176

Review-Url: https://codereview.chromium.org/2634713002
Cr-Commit-Position: refs/heads/master@{#443816}
Committed:
https://chromium.googlesource.com/chromium/src/+/65dfcc360fbc88445210a0e99aae...
==========

[commit-bot: I haz the power, 2017-01-15 15:35:24]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/65dfcc360fbc88445210a0e99aae...