third_party/WebKit/Source/modules/nfc/NFC.cpp - Issue 2634713002: Remove PageVisibilityObserver contextDestroyed() notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/nfc/NFC.cpp

Issue 2634713002: Remove PageVisibilityObserver contextDestroyed() notifications. (Closed)

Patch Set: prefer type aliases Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/nfc/NFC.cpp

diff --git a/third_party/WebKit/Source/modules/nfc/NFC.cpp b/third_party/WebKit/Source/modules/nfc/NFC.cpp

index 76b577cbd9c683a51f415e03ff092114a01de5f3..5a07ae7f4c318dbfeca9b941e6a95662d1afe9ca 100644

--- a/third_party/WebKit/Source/modules/nfc/NFC.cpp

+++ b/third_party/WebKit/Source/modules/nfc/NFC.cpp

@@ -604,8 +604,6 @@ void NFC::contextDestroyed(ExecutionContext*) {

m_callbacks.clear();

}

-void NFC::contextDestroyed(Page*) {}

// https://w3c.github.io/web-nfc/#writing-or-pushing-content

// https://w3c.github.io/web-nfc/#dom-nfc-push

ScriptPromise NFC::push(ScriptState* scriptState,