[debugger] whitelist some builtins as side-effect free.

[debugger] whitelist some builtins as side-effect free.


R=jgruber@chromium.org
BUG=v8:5821
Review-Url: https://codereview.chromium.org/2634523002
Cr-Commit-Position: refs/heads/master@{#42354}
Committed: https://chromium.googlesource.com/v8/v8/+/11cf146610a36d71c138864cc3685706992a2733

[Yang, 2017-01-13 09:42:08]

Please take a look.

[jgruber, 2017-01-13 10:08:02]

lgtm

https://codereview.chromium.org/2634523002/diff/1/src/debug/debug-evaluate.cc
File src/debug/debug-evaluate.cc (right):

https://codereview.chromium.org/2634523002/diff/1/src/debug/debug-evaluate.cc...
src/debug/debug-evaluate.cc:262: // Whitelist for intrinsics.
Nit: the comment and function name could be updated now that intrinsics/runtime
function checks are merged.

[Yang, 2017-01-16 06:16:46]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-16 06:16:46]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2634523002/#ps20001
(title: "fix comment")

[commit-bot: I haz the power, 2017-01-16 06:16:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 06:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 06:20:05]

Try jobs failed on following builders:
  v8_linux64_avx2_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...)
  v8_linux64_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/19180)
  v8_linux_gcc_compile_rel on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_gcc_compile_rel/bu...)
  v8_linux_nodcheck_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...)
  v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/15615)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/20891)

[Yang, 2017-01-16 06:31:41]

The CQ bit was checked by yangguo@chromium.org

[Yang, 2017-01-16 06:31:42]

The patchset sent to the CQ was uploaded after l-g-t-m from jgruber@chromium.org
Link to the patchset: https://codereview.chromium.org/2634523002/#ps40001
(title: "fix")

[commit-bot: I haz the power, 2017-01-16 06:31:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 06:57:55]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484548301783780,
"parent_rev": "c777b6e27203ccc926e736a910030880352ef1cd", "commit_rev":
"11cf146610a36d71c138864cc3685706992a2733"}

[commit-bot: I haz the power, 2017-01-16 06:57:59]

Description was changed from

==========
[debugger] whitelist some builtins as side-effect free.


R=jgruber@chromium.org
BUG=v8:5821
==========

to

==========
[debugger] whitelist some builtins as side-effect free.


R=jgruber@chromium.org
BUG=v8:5821

Review-Url: https://codereview.chromium.org/2634523002
Cr-Commit-Position: refs/heads/master@{#42354}
Committed:
https://chromium.googlesource.com/v8/v8/+/11cf146610a36d71c138864cc3685706992...
==========

[commit-bot: I haz the power, 2017-01-16 06:57:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/11cf146610a36d71c138864cc3685706992...

[Yang, 2017-01-16 13:20:31]

https://codereview.chromium.org/2634523002/diff/1/src/debug/debug-evaluate.cc
File src/debug/debug-evaluate.cc (right):

https://codereview.chromium.org/2634523002/diff/1/src/debug/debug-evaluate.cc...
src/debug/debug-evaluate.cc:262: // Whitelist for intrinsics.
On 2017/01/13 10:08:02, jgruber wrote:
> Nit: the comment and function name could be updated now that
intrinsics/runtime
> function checks are merged.

Done.