Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: src/debug/debug.h

Issue 2634523002: [debugger] whitelist some builtins as side-effect free. (Closed)
Patch Set: fix Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_DEBUG_DEBUG_H_ 5 #ifndef V8_DEBUG_DEBUG_H_
6 #define V8_DEBUG_DEBUG_H_ 6 #define V8_DEBUG_DEBUG_H_
7 7
8 #include "src/allocation.h" 8 #include "src/allocation.h"
9 #include "src/arguments.h" 9 #include "src/arguments.h"
10 #include "src/assembler.h" 10 #include "src/assembler.h"
(...skipping 562 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 573
574 void UpdateState(); 574 void UpdateState();
575 void UpdateHookOnFunctionCall(); 575 void UpdateHookOnFunctionCall();
576 void Unload(); 576 void Unload();
577 void SetNextBreakId() { 577 void SetNextBreakId() {
578 thread_local_.break_id_ = ++thread_local_.break_count_; 578 thread_local_.break_id_ = ++thread_local_.break_count_;
579 } 579 }
580 580
581 // Check whether there are commands in the command queue. 581 // Check whether there are commands in the command queue.
582 inline bool has_commands() const { return !command_queue_.IsEmpty(); } 582 inline bool has_commands() const { return !command_queue_.IsEmpty(); }
583 inline bool ignore_events() const { return is_suppressed_ || !is_active_; } 583 inline bool ignore_events() const {
584 return is_suppressed_ || !is_active_ || isolate_->needs_side_effect_check();
585 }
584 inline bool break_disabled() const { 586 inline bool break_disabled() const {
585 return break_disabled_ || in_debug_event_listener_; 587 return break_disabled_ || in_debug_event_listener_;
586 } 588 }
587 589
588 void clear_suspended_generator() { 590 void clear_suspended_generator() {
589 thread_local_.suspended_generator_ = Smi::kZero; 591 thread_local_.suspended_generator_ = Smi::kZero;
590 } 592 }
591 593
592 bool has_suspended_generator() const { 594 bool has_suspended_generator() const {
593 return thread_local_.suspended_generator_ != Smi::kZero; 595 return thread_local_.suspended_generator_ != Smi::kZero;
(...skipping 275 matching lines...) Expand 10 before | Expand all | Expand 10 after
869 Handle<Code> code); 871 Handle<Code> code);
870 static bool DebugBreakSlotIsPatched(Address pc); 872 static bool DebugBreakSlotIsPatched(Address pc);
871 static void ClearDebugBreakSlot(Isolate* isolate, Address pc); 873 static void ClearDebugBreakSlot(Isolate* isolate, Address pc);
872 }; 874 };
873 875
874 876
875 } // namespace internal 877 } // namespace internal
876 } // namespace v8 878 } // namespace v8
877 879
878 #endif // V8_DEBUG_DEBUG_H_ 880 #endif // V8_DEBUG_DEBUG_H_
OLDNEW
« no previous file with comments | « no previous file | src/debug/debug-evaluate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698