ElementVisibilityObserver: remove OOPIF checks.

ElementVisibilityObserver: remove OOPIF checks.

IntersectionObserver should now work for OOPIF.

BUG=615156
R=kenrb@chromium.org

Review-Url: https://codereview.chromium.org/2634113002
Cr-Commit-Position: refs/heads/master@{#444374}
Committed: https://chromium.googlesource.com/chromium/src/+/10fecf4ab18ee7f481d25ae31122bb099c9b7039

[mlamouri (slow - plz ping), 2017-01-16 14:18:01]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 14:18:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 15:40:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 15:40:34]

Dry run: This issue passed the CQ dry run.

[kenrb, 2017-01-16 20:07:22]

lgtm

[mlamouri (slow - plz ping), 2017-01-16 20:10:51]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2017-01-16 20:11:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kenrb, 2017-01-16 20:15:29]

You still need a Blink Core owner to review.

[commit-bot: I haz the power, 2017-01-16 20:17:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 20:17:15]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[mlamouri (slow - plz ping), 2017-01-17 09:42:03]

On 2017/01/16 at 20:15:29, kenrb wrote:
> You still need a Blink Core owner to review.

Yeah. I realised after pressing commit that you might not be a core owners too
but I was on my way out.

[mlamouri (slow - plz ping), 2017-01-17 09:42:25]

mlamouri@chromium.org changed reviewers:
+ jochen@chromium.org

[mlamouri (slow - plz ping), 2017-01-17 09:42:25]

jochen@, what about a friendly EMEA TBR? :)

[jochen (gone - plz use gerrit), 2017-01-17 09:54:48]

can you add a test for this?

[mlamouri (slow - plz ping), 2017-01-17 09:58:23]

On 2017/01/17 at 09:54:48, jochen wrote:
> can you add a test for this?

FWIW, it is tested by http/tests/media/autoplay-crossorigin.html which for some
reasons still do not pass with site-isolation enabled (I presume a loading
problem). I don't know how easy it would be to write a unit test for this in
Blink given that I would need to turn on site isolation. I'm happy to
investigate.

[jochen (gone - plz use gerrit), 2017-01-17 10:25:59]

it should be possible to add a layout test that now works when run with
run-webkit-tests --additional-driver-flag=--site-per-process, no?

[mlamouri (slow - plz ping), 2017-01-17 10:29:19]

On 2017/01/17 at 10:25:59, jochen wrote:
> it should be possible to add a layout test that now works when run with
run-webkit-tests --additional-driver-flag=--site-per-process, no?

This object isn't directly web exposed. The autoplay-crossorigin.html uses
ElementVisibilityObserver and is currently disabled for site-isolation. I don't
think we should have another test specific to autoplay. I think a unit test
would be more useful. Will check what I can do.

[mlamouri (slow - plz ping), 2017-01-17 18:58:45]

jochen@, I've added a unit test, PTAL.

This is very simply (check for no crash). I can make the unit tests more
invasive but even checking that the callback is run would require to depend too
heavily on the IntersectionObserver code.

[mlamouri (slow - plz ping), 2017-01-18 10:00:02]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 10:00:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 11:00:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 11:00:35]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[jochen (gone - plz use gerrit), 2017-01-18 12:31:42]

lgtm, thx

[mlamouri (slow - plz ping), 2017-01-18 12:33:53]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-01-18 12:33:54]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org
Link to the patchset: https://codereview.chromium.org/2634113002/#ps20001
(title: "with tests")

[commit-bot: I haz the power, 2017-01-18 12:34:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 13:29:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 13:29:17]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[mlamouri (slow - plz ping), 2017-01-18 13:41:58]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-01-18 13:41:59]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2634113002/#ps40001
(title: "add export")

[commit-bot: I haz the power, 2017-01-18 13:42:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 13:52:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 13:52:59]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlamouri (slow - plz ping), 2017-01-18 14:08:22]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2017-01-18 14:08:23]

The patchset sent to the CQ was uploaded after l-g-t-m from kenrb@chromium.org,
jochen@chromium.org
Link to the patchset: https://codereview.chromium.org/2634113002/#ps60001
(title: "non-exported-base")

[commit-bot: I haz the power, 2017-01-18 14:08:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 15:58:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1484748502788350,
"parent_rev": "7f8ed16176c1bacf9b9e27569ed151bf55cf319a", "commit_rev":
"10fecf4ab18ee7f481d25ae31122bb099c9b7039"}

[commit-bot: I haz the power, 2017-01-18 15:58:41]

Description was changed from

==========
ElementVisibilityObserver: remove OOPIF checks.

IntersectionObserver should now work for OOPIF.

BUG=615156
R=kenrb@chromium.org
==========

to

==========
ElementVisibilityObserver: remove OOPIF checks.

IntersectionObserver should now work for OOPIF.

BUG=615156
R=kenrb@chromium.org

Review-Url: https://codereview.chromium.org/2634113002
Cr-Commit-Position: refs/heads/master@{#444374}
Committed:
https://chromium.googlesource.com/chromium/src/+/10fecf4ab18ee7f481d25ae31122...
==========

[commit-bot: I haz the power, 2017-01-18 15:58:42]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/10fecf4ab18ee7f481d25ae31122...