Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(836)

Side by Side Diff: third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp

Issue 2634113002: ElementVisibilityObserver: remove OOPIF checks. (Closed)
Patch Set: non-exported-base Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "core/dom/ElementVisibilityObserver.h" 5 #include "core/dom/ElementVisibilityObserver.h"
6 6
7 #include "core/dom/DOMImplementation.h" 7 #include "core/dom/DOMImplementation.h"
8 #include "core/dom/Document.h" 8 #include "core/dom/Document.h"
9 #include "core/frame/RemoteFrame.h"
9 #include "core/html/HTMLDivElement.h" 10 #include "core/html/HTMLDivElement.h"
10 #include "core/html/HTMLDocument.h" 11 #include "core/html/HTMLDocument.h"
12 #include "core/loader/EmptyClients.h"
11 #include "core/testing/DummyPageHolder.h" 13 #include "core/testing/DummyPageHolder.h"
12 #include "testing/gtest/include/gtest/gtest.h" 14 #include "testing/gtest/include/gtest/gtest.h"
13 15
14 namespace blink { 16 namespace blink {
15 17
16 namespace { 18 namespace {
17 19
20 // Stub implementation of FrameLoaderClient for the purpose of testing. It will
21 // alow callers to set the parent/top frames by calling |setParent|. It is used
22 // in ElementVisibilityObserverTest in order to mock a RemoteFrame parent of a
23 // LocalFrame.
24 class StubFrameLoaderClient final : public EmptyFrameLoaderClient {
25 public:
26 Frame* parent() const override { return m_parent; }
27 Frame* top() const override { return m_parent; }
28
29 void setParent(Frame* frame) { m_parent = frame; }
30
31 DEFINE_INLINE_VIRTUAL_TRACE() {
32 visitor->trace(m_parent);
33 EmptyFrameLoaderClient::trace(visitor);
34 }
35
36 private:
37 WeakMember<Frame> m_parent = nullptr;
38 };
39
18 class ElementVisibilityObserverTest : public ::testing::Test { 40 class ElementVisibilityObserverTest : public ::testing::Test {
19 protected: 41 protected:
20 void SetUp() override { m_dummyPageHolder = DummyPageHolder::create(); } 42 void SetUp() override {
43 m_frameLoaderClient = new StubFrameLoaderClient();
44 m_dummyPageHolder = DummyPageHolder::create(
45 IntSize(), nullptr, m_frameLoaderClient, nullptr, nullptr);
46 }
47
48 void TearDown() override {
49 m_dummyPageHolder->frame().detach(FrameDetachType::Remove);
50 }
21 51
22 Document& document() { return m_dummyPageHolder->document(); } 52 Document& document() { return m_dummyPageHolder->document(); }
53 FrameHost& frameHost() { return m_dummyPageHolder->page().frameHost(); }
54 StubFrameLoaderClient* frameLoaderClient() const {
55 return m_frameLoaderClient;
56 }
23 57
24 private: 58 private:
25 std::unique_ptr<DummyPageHolder> m_dummyPageHolder; 59 std::unique_ptr<DummyPageHolder> m_dummyPageHolder;
60 Persistent<StubFrameLoaderClient> m_frameLoaderClient;
26 }; 61 };
27 62
28 TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) { 63 TEST_F(ElementVisibilityObserverTest, ObserveElementWithoutDocumentFrame) {
29 HTMLElement* element = HTMLDivElement::create( 64 HTMLElement* element = HTMLDivElement::create(
30 *DOMImplementation::create(document())->createHTMLDocument("test")); 65 *DOMImplementation::create(document())->createHTMLDocument("test"));
31 ElementVisibilityObserver* observer = 66 ElementVisibilityObserver* observer =
32 new ElementVisibilityObserver(element, nullptr); 67 new ElementVisibilityObserver(element, nullptr);
33 observer->start(); 68 observer->start();
34 observer->stop(); 69 observer->stop();
35 // It should not crash. 70 // It should not crash.
36 } 71 }
37 72
73 TEST_F(ElementVisibilityObserverTest, ObserveElementInRemoteFrame) {
74 Persistent<RemoteFrame> remoteFrame =
75 RemoteFrame::create(new EmptyRemoteFrameClient(), &frameHost(), nullptr);
76 frameLoaderClient()->setParent(remoteFrame);
77
78 Persistent<HTMLElement> element = HTMLDivElement::create(document());
79 ElementVisibilityObserver* observer =
80 new ElementVisibilityObserver(element, WTF::bind([](bool) {}));
81 observer->start();
82 observer->deliverObservationsForTesting();
83 observer->stop();
84 // It should not crash.
85 }
86
38 } // anonymous namespace 87 } // anonymous namespace
39 88
40 } // blink namespace 89 } // blink namespace
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/ElementVisibilityObserver.cpp ('k') | third_party/WebKit/Source/core/loader/EmptyClients.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698