Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2634053002: Show open task button only when applicable. (Closed)

Created:
3 years, 11 months ago by oka
Modified:
3 years, 11 months ago
Reviewers:
fukino
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show open task button only when applicable. In Quick View, the open task button should be shown only when 1. The dialog is full page mode, and 2. There is a task to open the file. In this CL, hasTask property is added to files-quick-view element and quick view controller sets it true only if 1 and 2 are satisfied. BUG=658448 TEST=manually checked the following cases: file type | volume | has open button -------------------------------------- image | Download | yes image | Drive | yes folder | Download | no folder | Drive | no CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2634053002 Cr-Commit-Position: refs/heads/master@{#444011} Committed: https://chromium.googlesource.com/chromium/src/+/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Patch Set 4 : Remove dead code #

Patch Set 5 : Rebased. #

Patch Set 6 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -69 lines) Patch
M ui/file_manager/file_manager/foreground/elements/files_quick_view.html View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/elements/files_quick_view.js View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/quick_view_controller.js View 1 2 3 4 5 7 chunks +82 lines, -67 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 34 (21 generated)
oka
.
3 years, 11 months ago (2017-01-16 12:02:29 UTC) #6
oka
.
3 years, 11 months ago (2017-01-16 12:47:50 UTC) #14
oka
PTAL.
3 years, 11 months ago (2017-01-16 12:49:58 UTC) #16
oka
Remove dead code
3 years, 11 months ago (2017-01-16 12:52:38 UTC) #17
oka
Rebased.
3 years, 11 months ago (2017-01-16 13:17:23 UTC) #18
fukino
lgtm with a nit.
3 years, 11 months ago (2017-01-17 06:48:01 UTC) #19
oka
Rebase.
3 years, 11 months ago (2017-01-17 08:51:28 UTC) #20
oka
On 2017/01/17 06:48:01, fukino wrote: > lgtm with a nit. What is the nit?
3 years, 11 months ago (2017-01-17 08:55:01 UTC) #21
fukino
On 2017/01/17 08:55:01, oka wrote: > On 2017/01/17 06:48:01, fukino wrote: > > lgtm with ...
3 years, 11 months ago (2017-01-17 09:24:44 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634053002/100001
3 years, 11 months ago (2017-01-17 09:25:45 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2634053002/100001
3 years, 11 months ago (2017-01-17 09:25:55 UTC) #30
oka
On 2017/01/17 09:24:44, fukino wrote: > On 2017/01/17 08:55:01, oka wrote: > > On 2017/01/17 ...
3 years, 11 months ago (2017-01-17 09:25:56 UTC) #31
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 09:31:28 UTC) #34
Message was sent while issue was closed.
Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/a9273bfae3e059a8b3d7448db387...

Powered by Google App Engine
This is Rietveld 408576698