Chromium Code Reviews
DescriptionShow open task button only when applicable.
In Quick View, the open task button should be shown only when
1. The dialog is full page mode, and
2. There is a task to open the file.
In this CL, hasTask property is added to files-quick-view element
and quick view controller sets it true only if 1 and 2 are satisfied.
BUG=658448
TEST=manually checked the following cases:
file type | volume | has open button
--------------------------------------
image | Download | yes
image | Drive | yes
folder | Download | no
folder | Drive | no
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2634053002
Cr-Commit-Position: refs/heads/master@{#444011}
Committed: https://chromium.googlesource.com/chromium/src/+/a9273bfae3e059a8b3d7448db387b3e8b3d7ff2d
Patch Set 1 #Patch Set 2 : . #Patch Set 3 : . #Patch Set 4 : Remove dead code #Patch Set 5 : Rebased. #Patch Set 6 : Rebase. #
Depends on Patchset: Messages
Total messages: 34 (21 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||