Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2631143002:
Refactor Quick View controller. (Closed)
|
Created:
3 years, 11 months ago by oka Modified:
3 years, 11 months ago Reviewers:
fukino CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRefactor Quick View controller.
Refactored the logic to fill parameters into quick view element
using switch instead of multiple if-s.
This is a preparation for the CL https://codereview.chromium.org/2634053002, which
shows open task button only when applicable.
BUG=658448
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Review-Url: https://codereview.chromium.org/2631143002
Cr-Commit-Position: refs/heads/master@{#444009}
Committed: https://chromium.googlesource.com/chromium/src/+/88a01ea6624dcffe4257a05e79c56ccd5eb31849
Patch Set 1 #Patch Set 2 : nit #
Total comments: 4
Patch Set 3 : Addressed comments. #
Dependent Patchsets: Messages
Total messages: 21 (14 generated)
Description was changed from ========== Refactor Quick View controller. BUG= ========== to ========== Refactor Quick View controller. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Refactor Quick View controller. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Refactor Quick View controller. Refactored the logic to fill in parameters to quick view element using switch instead of multiple if-s. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== Refactor Quick View controller. Refactored the logic to fill in parameters to quick view element using switch instead of multiple if-s. BUG=None CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
oka@chromium.org changed reviewers: + fukino@chromium.org
PTAL.
Description was changed from ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which\ shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
nit
Description was changed from ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which\ shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by oka@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm with nits https://codereview.chromium.org/2631143002/diff/20001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/quick_view_controller.js (right): https://codereview.chromium.org/2631143002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/quick_view_controller.js:323: * @type{!Promise<!File>} nit: space after @type https://codereview.chromium.org/2631143002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/quick_view_controller.js:348: this.metadataModel_.get([entry], ['contentThumbnailUrl']), nit: remove 2 spaces to correct indentation.
Addressed comments.
https://codereview.chromium.org/2631143002/diff/20001/ui/file_manager/file_ma... File ui/file_manager/file_manager/foreground/js/quick_view_controller.js (right): https://codereview.chromium.org/2631143002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/quick_view_controller.js:323: * @type{!Promise<!File>} On 2017/01/17 06:46:03, fukino wrote: > nit: space after @type Done. https://codereview.chromium.org/2631143002/diff/20001/ui/file_manager/file_ma... ui/file_manager/file_manager/foreground/js/quick_view_controller.js:348: this.metadataModel_.get([entry], ['contentThumbnailUrl']), On 2017/01/17 06:46:03, fukino wrote: > nit: remove 2 spaces to correct indentation. Done.
The CQ bit was checked by oka@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from fukino@chromium.org Link to the patchset: https://codereview.chromium.org/2631143002/#ps40001 (title: "Addressed comments.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484642753255310,
"parent_rev": "d280d3b7b888a5f8964e916cdc2360ebc7858418", "commit_rev":
"88a01ea6624dcffe4257a05e79c56ccd5eb31849"}
Message was sent while issue was closed.
Description was changed from ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Refactor Quick View controller. Refactored the logic to fill parameters into quick view element using switch instead of multiple if-s. This is a preparation for the CL https://codereview.chromium.org/2634053002, which shows open task button only when applicable. BUG=658448 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2631143002 Cr-Commit-Position: refs/heads/master@{#444009} Committed: https://chromium.googlesource.com/chromium/src/+/88a01ea6624dcffe4257a05e79c5... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/88a01ea6624dcffe4257a05e79c5... |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
