Changed EInsideLink to an enum class with an unsigned type.

Changed EInsideLink to an enum class with an unsigned type.

Changed EInsideLink to an enum class with an unsigned type, and added
'k' prefix to enum values as per the style convention.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield.

This is also pre-work to move EInsideLink to be generated in
ComputedStyleBase.

BUG=628043
Review-Url: https://codereview.chromium.org/2633633003
Cr-Commit-Position: refs/heads/master@{#443980}
Committed: https://chromium.googlesource.com/chromium/src/+/38cfdb247bfbe1d7438173ce3cf46e19394ca53e

[napper, 2017-01-13 05:16:23]

The CQ bit was checked by napper@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 05:16:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 06:46:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 06:46:35]

Dry run: This issue passed the CQ dry run.

[napper, 2017-01-15 22:47:30]

The CQ bit was checked by napper@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-15 22:47:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 00:12:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 00:12:58]

Dry run: This issue passed the CQ dry run.

[napper, 2017-01-16 00:25:26]

napper@chromium.org changed reviewers:
+ nainar@chromium.org

[nainar, 2017-01-16 22:06:43]

On 2017/01/16 at 00:25:34, napper wrote:
> 

Sorry for the late feedback on this - first day back today! :)

[nainar, 2017-01-16 22:06:50]

lgtm

[napper, 2017-01-16 23:05:46]

The CQ bit was checked by napper@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:05:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 23:11:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 23:11:50]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[napper, 2017-01-16 23:13:25]

napper@chromium.org changed reviewers:
+ sashab@chromium.org

[napper, 2017-01-16 23:14:21]

Adding Sasha for OWNERS.

[sashab, 2017-01-17 01:02:41]

LGTM & great CL desc

[haraken, 2017-01-17 01:05:36]

owner LGTM

[napper, 2017-01-17 02:06:03]

The CQ bit was checked by napper@chromium.org

[commit-bot: I haz the power, 2017-01-17 02:06:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 03:39:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484618763158790,
"parent_rev": "24f1eede17d4d2515fb0fb0d168f8a35cef9a851", "commit_rev":
"38cfdb247bfbe1d7438173ce3cf46e19394ca53e"}

[commit-bot: I haz the power, 2017-01-17 03:39:34]

Description was changed from

==========
Changed EInsideLink to an enum class with an unsigned type.

Changed EInsideLink to an enum class with an unsigned type, and added
'k' prefix to enum values as per the style convention.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield.

This is also pre-work to move EInsideLink to be generated in
ComputedStyleBase.

BUG=628043
==========

to

==========
Changed EInsideLink to an enum class with an unsigned type.

Changed EInsideLink to an enum class with an unsigned type, and added
'k' prefix to enum values as per the style convention.

Changing it to an enum class enforces better namespacing and code
practices. Adding the unsigned underlying type is pre-work for when the
class is eventually stored as an enum bitfield.

This is also pre-work to move EInsideLink to be generated in
ComputedStyleBase.

BUG=628043

Review-Url: https://codereview.chromium.org/2633633003
Cr-Commit-Position: refs/heads/master@{#443980}
Committed:
https://chromium.googlesource.com/chromium/src/+/38cfdb247bfbe1d7438173ce3cf4...
==========

[commit-bot: I haz the power, 2017-01-17 03:39:35]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/38cfdb247bfbe1d7438173ce3cf4...