Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Unified Diff: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp

Issue 2633633003: Changed EInsideLink to an enum class with an unsigned type. (Closed)
Patch Set: Rebase. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
diff --git a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
index d837619411d9c3ac0a08528f86939465039dc0f2..cddb5ad69b8e001cfb6d6f97e7bd118f08b5fb8a 100644
--- a/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
+++ b/third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp
@@ -693,11 +693,11 @@ PassRefPtr<ComputedStyle> StyleResolver::styleForElement(
if (element->isLink()) {
state.style()->setIsLink(true);
EInsideLink linkState = state.elementLinkState();
- if (linkState != NotInsideLink) {
+ if (linkState != EInsideLink::kNotInsideLink) {
bool forceVisited = InspectorInstrumentation::forcePseudoState(
element, CSSSelector::PseudoVisited);
if (forceVisited)
- linkState = InsideVisitedLink;
+ linkState = EInsideLink::kInsideVisitedLink;
}
state.style()->setInsideLink(linkState);
}
@@ -1114,7 +1114,7 @@ bool StyleResolver::applyAnimatedStandardProperties(
if (state.animationUpdate().isEmpty())
return false;
- if (state.style()->insideLink() != NotInsideLink) {
+ if (state.style()->insideLink() != EInsideLink::kNotInsideLink) {
DCHECK(state.applyPropertyToRegularStyle());
state.setApplyPropertyToVisitedLinkStyle(true);
}
@@ -1541,7 +1541,7 @@ void StyleResolver::applyMatchedProperties(StyleResolverState& state,
if (!shouldUpdateNeedsApplyPass && !needsApplyPass.get(priority, isImportant))
return;
- if (state.style()->insideLink() != NotInsideLink) {
+ if (state.style()->insideLink() != EInsideLink::kNotInsideLink) {
for (const auto& matchedProperties : range) {
unsigned linkMatchType = matchedProperties.m_types.linkMatchType;
// FIXME: It would be nicer to pass these as arguments but that requires

Powered by Google App Engine
This is Rietveld 408576698