HTMLAnchorElement.text should not be readonly

HTMLAnchorElement.text should not be readonly

HTMLAnchorElement.text should not be readonly as per the HTML specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/text-level-semantics.html#dom-a-text

On setting HTMLAnchorElement.text, we must act as if the textContent IDL
attribute on the element had been set to the new value. This CL updates Blink
to behave accordingly.

The new behavior is consistent with Firefox 29 and IE11.

R=arv@chromium.org, eseidel@chromium.org
TEST=fast/dom/HTMLAnchorElement/set-text.html
BUG=369950
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173458

[arv (Not doing code reviews), 2014-05-06 22:15:05]

LGTM

... but I think there is room for improvement here. It can be done in a
different CL if you prefer.

https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
File Source/core/html/HTMLAnchorElement.cpp (right):

https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.cpp:347: return innerText();
This one looks wrong too. It should be textContent and not innerText. It should
be detectable doing:

var div = document.createElement('div');
div.innerHTML = '<a>a<br>b</a>';
var a = div.firstChild;
shouldBeEqualToString('a.text', 'ab');

https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
File Source/core/html/HTMLAnchorElement.idl (right):

https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
Source/core/html/HTMLAnchorElement.idl:34: attribute DOMString text;
Can you do [ImplementedAs=textContent]? That would also fix the bug in the text
setter.

[Inactive, 2014-05-06 22:23:43]

On 2014/05/06 22:15:05, arv wrote:
> LGTM
> 
> ... but I think there is room for improvement here. It can be done in a
> different CL if you prefer.
> 
>
https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
> File Source/core/html/HTMLAnchorElement.cpp (right):
> 
>
https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
> Source/core/html/HTMLAnchorElement.cpp:347: return innerText();
> This one looks wrong too. It should be textContent and not innerText. It
should
> be detectable doing:
> 
> var div = document.createElement('div');
> div.innerHTML = '<a>a<br>b</a>';
> var a = div.firstChild;
> shouldBeEqualToString('a.text', 'ab');
> 
>
https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
> File Source/core/html/HTMLAnchorElement.idl (right):
> 
>
https://codereview.chromium.org/263353004/diff/1/Source/core/html/HTMLAnchorE...
> Source/core/html/HTMLAnchorElement.idl:34: attribute DOMString text;
> Can you do [ImplementedAs=textContent]? That would also fix the bug in the
text
> setter.

I agree with your proposal. I did not want to check the behavior of the text
getter in the same patch. However, I am happy to address this in a follow-up
patch.

[Inactive, 2014-05-06 23:45:32]

Could an API OWNER please take a look as well?

[tkent, 2014-05-07 01:20:50]

lgtm

[Inactive, 2014-05-07 01:32:14]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-05-07 01:33:10]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/263353004/1

[commit-bot: I haz the power, 2014-05-07 03:36:49]

Change committed as 173458