Source/core/html/HTMLAnchorElement.idl - Issue 263353004: HTMLAnchorElement.text should not be readonly

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/core/html/HTMLAnchorElement.idl

Issue 263353004: HTMLAnchorElement.text should not be readonly (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« Source/core/html/HTMLAnchorElement.cpp ('K') | « Source/core/html/HTMLAnchorElement.cpp ('k') | no next file » | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.	2 * Copyright (C) 2006, 2007, 2009, 2010 Apple Inc. All rights reserved.

3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>	3 * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>

4 *	4 *

5 * This library is free software; you can redistribute it and/or	5 * This library is free software; you can redistribute it and/or

6 * modify it under the terms of the GNU Library General Public	6 * modify it under the terms of the GNU Library General Public

7 * License as published by the Free Software Foundation; either	7 * License as published by the Free Software Foundation; either

8 * version 2 of the License, or (at your option) any later version.	8 * version 2 of the License, or (at your option) any later version.

9 *	9 *

10 * This library is distributed in the hope that it will be useful,	10 * This library is distributed in the hope that it will be useful,

(...skipping 13 matching lines...) Expand all Loading...
24 [Reflect] attribute DOMString download;	24 [Reflect] attribute DOMString download;

25 [Reflect] attribute DOMString hreflang;	25 [Reflect] attribute DOMString hreflang;

26 [Reflect] attribute DOMString name;	26 [Reflect] attribute DOMString name;

27 [Reflect] attribute DOMString ping;	27 [Reflect] attribute DOMString ping;

28 [Reflect] attribute DOMString rel;	28 [Reflect] attribute DOMString rel;

29 [Reflect] attribute DOMString rev;	29 [Reflect] attribute DOMString rev;

30 [Reflect] attribute DOMString shape;	30 [Reflect] attribute DOMString shape;

31 [Reflect] attribute DOMString target;	31 [Reflect] attribute DOMString target;

32 [Reflect] attribute DOMString type;	32 [Reflect] attribute DOMString type;

33	33

34 readonly attribute DOMString text;	34 attribute DOMString text;
	arv (Not doing code reviews) 2014/05/06 22:15:06 Can you do [ImplementedAs=textContent]? That would Can you do [ImplementedAs=textContent]? That would also fix the bug in the text setter.
35	35

36 [Reflect, RuntimeEnabled=SubresourceIntegrity] attribute DOMString integrity ;	36 [Reflect, RuntimeEnabled=SubresourceIntegrity] attribute DOMString integrity ;

37 };	37 };

38	38

39 HTMLAnchorElement implements URLUtils;	39 HTMLAnchorElement implements URLUtils;

OLD	NEW