Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: Source/core/html/HTMLAnchorElement.cpp

Issue 263353004: HTMLAnchorElement.text should not be readonly (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed. 5 * Copyright (C) 2003, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights reserv ed.
6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 { 330 {
331 // Skip the supportsFocus check in HTMLElement. 331 // Skip the supportsFocus check in HTMLElement.
332 return Element::tabIndex(); 332 return Element::tabIndex();
333 } 333 }
334 334
335 AtomicString HTMLAnchorElement::target() const 335 AtomicString HTMLAnchorElement::target() const
336 { 336 {
337 return getAttribute(targetAttr); 337 return getAttribute(targetAttr);
338 } 338 }
339 339
340 void HTMLAnchorElement::setText(const String& text)
341 {
342 setTextContent(text);
343 }
340 344
341 String HTMLAnchorElement::text() 345 String HTMLAnchorElement::text()
342 { 346 {
343 return innerText(); 347 return innerText();
arv (Not doing code reviews) 2014/05/06 22:15:06 This one looks wrong too. It should be textContent
344 } 348 }
345 349
346 bool HTMLAnchorElement::isLiveLink() const 350 bool HTMLAnchorElement::isLiveLink() const
347 { 351 {
348 return isLink() && !rendererIsEditable(); 352 return isLink() && !rendererIsEditable();
349 } 353 }
350 354
351 void HTMLAnchorElement::sendPings(const KURL& destinationURL) 355 void HTMLAnchorElement::sendPings(const KURL& destinationURL)
352 { 356 {
353 const AtomicString& pingValue = getAttribute(pingAttr); 357 const AtomicString& pingValue = getAttribute(pingAttr);
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
582 preconnectToURL(url, motivation); 586 preconnectToURL(url, motivation);
583 m_hasIssuedPreconnect = true; 587 m_hasIssuedPreconnect = true;
584 } 588 }
585 589
586 bool HTMLAnchorElement::isInteractiveContent() const 590 bool HTMLAnchorElement::isInteractiveContent() const
587 { 591 {
588 return isLink(); 592 return isLink();
589 } 593 }
590 594
591 } 595 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698