Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issue 2633513003: Rip out old code for finding reference test for an alert. (Closed)

Created:
3 years, 11 months ago by sullivan
Modified:
3 years, 11 months ago
Reviewers:
eakuefner, shatch
CC:
catapult-reviews_chromium.org, perf-dashboard-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Rip out old code for finding reference test for an alert. This will be replaced with code that stores the ref build path with the alert, which is much simpler and faster. Step 2 of the plan outlined here: https://docs.google.com/document/d/1HCoC__FPYwnuZRmnA-cmi6kKoWGq8YlFU9y3KRFbFnU/edit# BUG=catapult:#2887 Review-Url: https://codereview.chromium.org/2633513003 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/9ab60e83193a7322b42169b22560d926c5ebba0e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -68 lines) Patch
M dashboard/dashboard/elements/group-report-page.html View 4 chunks +2 lines, -48 lines 0 comments Download
M dashboard/dashboard/group_report.py View 3 chunks +0 lines, -20 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
sullivan
3 years, 11 months ago (2017-01-13 16:50:01 UTC) #4
eakuefner
lgtm
3 years, 11 months ago (2017-01-13 18:04:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633513003/1
3 years, 11 months ago (2017-01-13 18:05:35 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 18:07:17 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698