Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: dashboard/dashboard/group_report.py

Issue 2633513003: Rip out old code for finding reference test for an alert. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dashboard/dashboard/elements/group-report-page.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dashboard/dashboard/group_report.py
diff --git a/dashboard/dashboard/group_report.py b/dashboard/dashboard/group_report.py
index 9e96e1ff44957bc79e5b97745c25cf481b384f79..1997ac24b84c9b9d7dcbbd4696af99af78c2ec44 100644
--- a/dashboard/dashboard/group_report.py
+++ b/dashboard/dashboard/group_report.py
@@ -10,7 +10,6 @@ from google.appengine.ext import ndb
from dashboard import alerts
from dashboard import chart_handler
-from dashboard import list_tests
from dashboard import update_test_suites
from dashboard.common import request_handler
from dashboard.common import utils
@@ -182,11 +181,6 @@ class GroupReportHandler(chart_handler.ChartHandler):
values = {
'alert_list': alert_dicts[:_DISPLAY_LIMIT],
- # This code for getting the subtests is supposed to be used to sort out
- # which metrics are "core" vs "non-core". But it's extremely slow, and
- # also doesn't seem to work very well. Turn it off for now:
- # https://github.com/catapult-project/catapult/issues/2877
- #'subtests': _GetSubTestsForAlerts(alert_dicts),
'bug_id': bug_id,
'test_suites': update_test_suites.FetchCachedTestSuites(),
'selected_keys': selected_keys,
@@ -205,20 +199,6 @@ def _IsInt(x):
return False
-def _GetSubTestsForAlerts(alert_list):
- """Gets subtest dict for list of alerts."""
- subtests = {}
- for alert in alert_list:
- bot_name = alert['master'] + '/' + alert['bot']
- testsuite = alert['testsuite']
- if bot_name not in subtests:
- subtests[bot_name] = {}
- if testsuite not in subtests[bot_name]:
- subtests[bot_name][testsuite] = list_tests.GetSubTests(
- testsuite, [bot_name])
- return subtests
-
-
def _GetOverlaps(anomalies, start, end):
"""Gets the minimum range for the list of anomalies.
« no previous file with comments | « dashboard/dashboard/elements/group-report-page.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698