Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2633353002: [async-await] Remove RejectPromiseNoDebugEvent (Closed)

Created:
3 years, 11 months ago by jgruber
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[async-await] Remove RejectPromiseNoDebugEvent Just desugar directly into the runtime call instead. BUG=v8:5639 Review-Url: https://codereview.chromium.org/2633353002 Cr-Commit-Position: refs/heads/master@{#42492} Committed: https://chromium.googlesource.com/v8/v8/+/27edf11e04d0b318eb7530a738c74bd7c1884d5a

Patch Set 1 #

Patch Set 2 : Rebase on top of latest changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M src/contexts.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/js/async-await.js View 1 2 chunks +0 lines, -6 lines 0 comments Download
M src/parsing/parser.cc View 1 1 chunk +6 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (15 generated)
jgruber
3 years, 11 months ago (2017-01-17 15:57:05 UTC) #6
gsathya
On 2017/01/17 15:57:05, jgruber wrote: With this change isolate->promise_reject() is only called with debug_event=true. Can ...
3 years, 11 months ago (2017-01-17 16:00:55 UTC) #7
jgruber
On 2017/01/17 16:00:55, gsathya wrote: > On 2017/01/17 15:57:05, jgruber wrote: > > With this ...
3 years, 11 months ago (2017-01-18 12:49:02 UTC) #10
gsathya
lgtm
3 years, 11 months ago (2017-01-18 18:59:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633353002/20001
3 years, 11 months ago (2017-01-19 08:36:50 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/32809)
3 years, 11 months ago (2017-01-19 08:39:59 UTC) #17
jgruber
+yang for src/js +vogelheim for parsing/ PTAL
3 years, 11 months ago (2017-01-19 08:45:45 UTC) #19
Yang
On 2017/01/19 08:45:45, jgruber wrote: > +yang for src/js > +vogelheim for parsing/ > > ...
3 years, 11 months ago (2017-01-19 08:47:47 UTC) #20
vogelheim
lgtm for src/parsing/..
3 years, 11 months ago (2017-01-19 08:48:20 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2633353002/20001
3 years, 11 months ago (2017-01-19 08:49:00 UTC) #23
commit-bot: I haz the power
3 years, 11 months ago (2017-01-19 08:50:48 UTC) #26
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/27edf11e04d0b318eb7530a738c74bd7c18...

Powered by Google App Engine
This is Rietveld 408576698