Add a new histogram for EngagementScore to check whether it's zero

(1) Add a new histogram for EngagementScore to check whether it's zero
or non-zero.

(2) The score is treated as 0 if it's less than  ScoreCleanupThreshold.

BUG=656834
Review-Url: https://codereview.chromium.org/2633283002
Cr-Commit-Position: refs/heads/master@{#446956}
Committed: https://chromium.googlesource.com/chromium/src/+/169ed39de473bb196dcb5960e4c19ced3336de4e

[charleszhao, 2017-01-17 06:28:37]

Description was changed from

==========
(1) Add a new histogram for EngagementScore to check whether it's zero
or non-zero.

(2) The score is treated as 0 if it's less than  ScoreCleanupThreshold.

BUG=656834
==========

to

==========
(1) Add a new histogram for EngagementScore to check whether it's zero
or non-zero.

(2) The score is treated as 0 if it's less than  ScoreCleanupThreshold.

BUG=656834
==========

[charleszhao, 2017-01-17 06:28:37]

charleszhao@chromium.org changed reviewers:
+ kcarattini@chromium.org

[charleszhao, 2017-01-17 06:29:01]

The CQ bit was checked by charleszhao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 06:29:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 07:27:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 07:27:08]

Dry run: This issue passed the CQ dry run.

[charleszhao, 2017-01-18 22:21:46]

charleszhao@chromium.org changed reviewers:
+ dominickn@chromium.org

[kcarattini, 2017-01-18 23:53:45]

Thanks for doing this!

Kendra

https://codereview.chromium.org/2633283002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2633283002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:62462: + 
<owner>calamity@chromium.org</owner>
I think leave out calamity and add me instead, he doesn't work on this anymore.

[charleszhao, 2017-01-19 22:38:20]

https://codereview.chromium.org/2633283002/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2633283002/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:62462: + 
<owner>calamity@chromium.org</owner>
On 2017/01/18 23:53:45, kcarattini wrote:
> I think leave out calamity and add me instead, he doesn't work on this
anymore.

Done.

[dominickn, 2017-01-20 02:11:53]

Thanks Charles

https://codereview.chromium.org/2633283002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_metrics.cc (right):

https://codereview.chromium.org/2633283002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_metrics.cc:102: const double
threshold_0 = SiteEngagementScore::GetScoreCleanupThreshold();
I think you can just compare score == 0 here rather than the cleanup threshold.
Scores can be below the cleanup threshold for an arbitrarily long length of time
(we only cleanup after startup, and if Chrome has been open but idle for some
number of hours, i.e. no engagement is being earned).

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62461: +<histogram
name="SiteEngagementService.EngagementScore.Zero">
Call this EngagementScore.IsZero.

add enum="Boolean" in the histogram tag

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62464: + 
<owner>charleszhao@chromium.org</owner>
The owners should be sorted in alphabetical order: you first, then me, then
kcarattini.

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62467: +   
SiteEngagementService.EngagementScore, but only counted as nearly-zero or
Change this to say, "The distribution of zero versus non-zero engagement scores
accumulated by the user, recorded at the same time as
SiteEngagementService.EngagementScore"

[dominickn, 2017-01-20 02:12:29]

Also: please remove the (1) from the title

[charleszhao, 2017-01-20 03:17:01]

Thanks Kendra, Dom.

https://codereview.chromium.org/2633283002/diff/20001/chrome/browser/engageme...
File chrome/browser/engagement/site_engagement_metrics.cc (right):

https://codereview.chromium.org/2633283002/diff/20001/chrome/browser/engageme...
chrome/browser/engagement/site_engagement_metrics.cc:102: const double
threshold_0 = SiteEngagementScore::GetScoreCleanupThreshold();
On 2017/01/20 02:11:53, dominickn wrote:
> I think you can just compare score == 0 here rather than the cleanup
threshold.
> Scores can be below the cleanup threshold for an arbitrarily long length of
time
> (we only cleanup after startup, and if Chrome has been open but idle for some
> number of hours, i.e. no engagement is being earned).

Done.

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62461: +<histogram
name="SiteEngagementService.EngagementScore.Zero">
On 2017/01/20 02:11:53, dominickn wrote:
> Call this EngagementScore.IsZero.
> 
> add enum="Boolean" in the histogram tag

Done.

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62461: +<histogram
name="SiteEngagementService.EngagementScore.Zero">
On 2017/01/20 02:11:53, dominickn wrote:
> Call this EngagementScore.IsZero.
> 
> add enum="Boolean" in the histogram tag

Done.

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62464: + 
<owner>charleszhao@chromium.org</owner>
On 2017/01/20 02:11:53, dominickn wrote:
> The owners should be sorted in alphabetical order: you first, then me, then
> kcarattini.

Done.

https://codereview.chromium.org/2633283002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:62467: +   
SiteEngagementService.EngagementScore, but only counted as nearly-zero or
On 2017/01/20 02:11:53, dominickn wrote:
> Change this to say, "The distribution of zero versus non-zero engagement
scores
> accumulated by the user, recorded at the same time as
> SiteEngagementService.EngagementScore"

Done.

[dominickn, 2017-01-23 02:51:39]

lgtm, thanks Charles

[kcarattini, 2017-01-23 03:07:09]

lgtm

[charleszhao, 2017-01-23 03:52:45]

The CQ bit was checked by charleszhao@chromium.org

[commit-bot: I haz the power, 2017-01-23 03:52:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 04:45:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 04:45:18]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[charleszhao, 2017-01-23 22:31:18]

The CQ bit was checked by charleszhao@chromium.org

[charleszhao, 2017-01-23 22:31:19]

The CQ bit was unchecked by charleszhao@chromium.org

[charleszhao, 2017-01-23 22:48:23]

The CQ bit was checked by charleszhao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-23 22:49:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-23 23:52:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-23 23:52:11]

Dry run: This issue passed the CQ dry run.

[charleszhao, 2017-01-24 06:41:58]

The CQ bit was checked by charleszhao@chromium.org

[commit-bot: I haz the power, 2017-01-24 06:42:16]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 06:49:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 06:49:23]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dominickn, 2017-01-24 06:52:40]

You need a reviewer for tools/metrics/histograms/histograms.xml

[charleszhao, 2017-01-24 07:20:13]

On 2017/01/24 06:52:40, dominickn wrote:
> You need a reviewer for tools/metrics/histograms/histograms.xml

Thanks! Dom.

[charleszhao, 2017-01-24 07:22:36]

charleszhao@chromium.org changed reviewers:
+ jwd@chromium.org

[charleszhao, 2017-01-24 07:53:25]

On 2017/01/24 07:20:13, charleszhao wrote:
> On 2017/01/24 06:52:40, dominickn wrote:
> > You need a reviewer for tools/metrics/histograms/histograms.xml
> 
> Thanks! Dom.

Hi jwd, need owner review for 1 file:
tools/metrics/histograms/histograms.xml

[charleszhao, 2017-01-24 07:54:09]

Thanks jwd for the owner review!

[jwd, 2017-01-24 21:34:13]

lgtm

[charleszhao, 2017-01-24 22:20:13]

The CQ bit was checked by charleszhao@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:21:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[charleszhao, 2017-01-24 22:21:37]

The CQ bit was unchecked by charleszhao@chromium.org

[charleszhao, 2017-01-24 22:22:01]

The CQ bit was checked by charleszhao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-24 22:22:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-24 22:29:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-24 22:29:21]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[charleszhao, 2017-01-29 22:04:36]

The CQ bit was checked by charleszhao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-29 22:04:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-29 23:44:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-29 23:44:43]

Dry run: This issue passed the CQ dry run.

[charleszhao, 2017-01-30 03:46:43]

The CQ bit was checked by charleszhao@chromium.org

[commit-bot: I haz the power, 2017-01-30 03:46:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-30 03:50:39]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1485748003464790,
"parent_rev": "2112ddfabe748e6a6a6f9fdbb7de7ade58326957", "commit_rev":
"169ed39de473bb196dcb5960e4c19ced3336de4e"}

[commit-bot: I haz the power, 2017-01-30 03:51:37]

Description was changed from

==========
(1) Add a new histogram for EngagementScore to check whether it's zero
or non-zero.

(2) The score is treated as 0 if it's less than  ScoreCleanupThreshold.

BUG=656834
==========

to

==========
(1) Add a new histogram for EngagementScore to check whether it's zero
or non-zero.

(2) The score is treated as 0 if it's less than  ScoreCleanupThreshold.

BUG=656834

Review-Url: https://codereview.chromium.org/2633283002
Cr-Commit-Position: refs/heads/master@{#446956}
Committed:
https://chromium.googlesource.com/chromium/src/+/169ed39de473bb196dcb5960e4c1...
==========

[commit-bot: I haz the power, 2017-01-30 03:51:38]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/169ed39de473bb196dcb5960e4c1...