Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3194)

Unified Diff: chrome/browser/engagement/site_engagement_metrics.cc

Issue 2633283002: Add a new histogram for EngagementScore to check whether it's zero (Closed)
Patch Set: Changed histogram.xml description and owner order. Also changed the method of counting zero. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/engagement/site_engagement_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/engagement/site_engagement_metrics.cc
diff --git a/chrome/browser/engagement/site_engagement_metrics.cc b/chrome/browser/engagement/site_engagement_metrics.cc
index 83db74ed29d65efa49df7313928f60c65962167c..ab2f62b62973984d4147e1180f0ef4ab7cd709d0 100644
--- a/chrome/browser/engagement/site_engagement_metrics.cc
+++ b/chrome/browser/engagement/site_engagement_metrics.cc
@@ -6,6 +6,7 @@
#include "base/metrics/histogram_macros.h"
#include "base/strings/string_number_conversions.h"
+#include "chrome/browser/engagement/site_engagement_score.h"
namespace {
@@ -42,6 +43,9 @@ const char SiteEngagementMetrics::kEngagementScoreHistogramHTTP[] =
const char SiteEngagementMetrics::kEngagementScoreHistogramHTTPS[] =
"SiteEngagementService.EngagementScore.HTTPS";
+const char SiteEngagementMetrics::kEngagementScoreHistogramIsZero[] =
+ "SiteEngagementService.EngagementScore.IsZero";
+
const char SiteEngagementMetrics::kOriginsWithMaxEngagementHistogram[] =
"SiteEngagementService.OriginsWithMaxEngagement";
@@ -95,9 +99,11 @@ void SiteEngagementMetrics::RecordEngagementScores(
for (size_t i = 0; i < arraysize(kEngagementBucketHistogramBuckets); ++i)
score_buckets[kEngagementBucketHistogramBuckets[i]] = 0;
+ const double threshold_0 = std::numeric_limits<double>::epsilon();;
for (const auto& value : score_map) {
double score = value.second;
UMA_HISTOGRAM_COUNTS_100(kEngagementScoreHistogram, score);
+ UMA_HISTOGRAM_BOOLEAN(kEngagementScoreHistogramIsZero, score < threshold_0);
if (value.first.SchemeIs(url::kHttpsScheme)) {
UMA_HISTOGRAM_COUNTS_100(kEngagementScoreHistogramHTTPS, score);
https_engagement += score;
« no previous file with comments | « chrome/browser/engagement/site_engagement_metrics.h ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698