Fix broken quick view in non-local volumes.

Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
TEST=Preview works on Drive, Downloads, ZIP archive and RAR archive.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2633053003
Cr-Commit-Position: refs/heads/master@{#444032}
Committed: https://chromium.googlesource.com/chromium/src/+/d72441d795c9e7a397c96ddbb79409e22fc73ea3

[Shuhei Takahashi, 2017-01-16 11:31:38]

Description was changed from

==========
Fix broken quick view in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This change restricts the volume types which quick view supports
previews in.

BUG=N/A
TEST=Broken <img> is not shown in MTP and media views.
==========

to

==========
Fix broken quick view in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This change restricts the volume types which quick view supports
previews in.

BUG=N/A
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-16 11:34:58]

Description was changed from

==========
Fix broken quick view in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This change restricts the volume types which quick view supports
previews in.

BUG=N/A
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This change restricts the volume types for which quick view supports
previews.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-16 11:43:22]

Description was changed from

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This change restricts the volume types for which quick view supports
previews.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on DRIVE
or PROVIDED volumes (see MultiMetadataProvider.prototype.get()), so
this patch changes behavior on ARCHIVE, MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-16 11:59:17]

Description was changed from

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on DRIVE
or PROVIDED volumes (see MultiMetadataProvider.prototype.get()), so
this patch changes behavior on ARCHIVE, MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on DRIVE
or PROVIDED volumes (see MultiMetadataProvider.prototype.get()), so
this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-16 11:59:57]

Description was changed from

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on DRIVE
or PROVIDED volumes (see MultiMetadataProvider.prototype.get()), so
this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-16 12:01:37]

Description was changed from

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
TEST=Preview works on Drive, Downloads, ZIP archive and RAR archive.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Shuhei Takahashi, 2017-01-16 12:03:56]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 12:04:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 12:13:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 12:13:04]

Dry run: Try jobs failed on following builders:
  closure_compilation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compila...)

[Shuhei Takahashi, 2017-01-17 07:13:40]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 07:13:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 07:38:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 07:38:15]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2017-01-17 08:04:02]

nya@chromium.org changed reviewers:
+ oka@chromium.org

[Shuhei Takahashi, 2017-01-17 08:04:02]

oka: PTAL

[oka, 2017-01-17 09:22:57]

I refactored controller https://codereview.chromium.org/2631143002. Could you
rebase? Thank you.

https://codereview.chromium.org/2633053003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_controller.js
(right):

https://codereview.chromium.org/2633053003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_controller.js:399: if
(item.externalFileUrl || type === '.folder') {
Maybe this item.externalFileUrl should be changed to !localFile.
Because presumably pdf/texts on MTP are not shown in webview.

If this externalFileUrl can be removed, please also remove 'externalFileUrl' in
L270.

[Shuhei Takahashi, 2017-01-17 11:26:50]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 11:26:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2017-01-17 11:48:29]

Thanks for heads-up. I've rebased the patch onto ToT.

https://codereview.chromium.org/2633053003/diff/40001/ui/file_manager/file_ma...
File ui/file_manager/file_manager/foreground/js/quick_view_controller.js
(right):

https://codereview.chromium.org/2633053003/diff/40001/ui/file_manager/file_ma...
ui/file_manager/file_manager/foreground/js/quick_view_controller.js:399: if
(item.externalFileUrl || type === '.folder') {
On 2017/01/17 09:22:57, oka wrote:
> Maybe this item.externalFileUrl should be changed to !localFile.
> Because presumably pdf/texts on MTP are not shown in webview.
> 
> If this externalFileUrl can be removed, please also remove 'externalFileUrl'
in
> L270.

Done.

[commit-bot: I haz the power, 2017-01-17 11:50:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 11:50:37]

Dry run: This issue passed the CQ dry run.

[oka, 2017-01-17 12:06:01]

lgtm

Thank you!

[Shuhei Takahashi, 2017-01-17 12:11:47]

The CQ bit was checked by nya@chromium.org

[commit-bot: I haz the power, 2017-01-17 12:11:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 12:15:18]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1484655107319400,
"parent_rev": "ac8542bf73a577de118caaa42cd5baee9f11825f", "commit_rev":
"d72441d795c9e7a397c96ddbb79409e22fc73ea3"}

[commit-bot: I haz the power, 2017-01-17 12:15:48]

Description was changed from

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
TEST=Preview works on Drive, Downloads, ZIP archive and RAR archive.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Fix broken quick previews in non-local volumes.

In MTP and media view volumes, quick view was failing to show
previews of media files because WebView does not have
permissions to access those files.

This patch restricts the volume types for which quick view supports
previews, so that broken <img> is not shown to users.

Note that |item.externalFileUrl| is filled if and only if files are on
DRIVE or PROVIDED volumes (see MultiMetadataProvider.prototype.get()),
so this patch changes behavior only on MTP, MEDIA_VIEW volumes.

BUG=681517
TEST=Broken <img> is not shown in MTP and media views.
TEST=Preview works on Drive, Downloads, ZIP archive and RAR archive.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2633053003
Cr-Commit-Position: refs/heads/master@{#444032}
Committed:
https://chromium.googlesource.com/chromium/src/+/d72441d795c9e7a397c96ddbb794...
==========

[commit-bot: I haz the power, 2017-01-17 12:15:49]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/d72441d795c9e7a397c96ddbb794...