Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java

Issue 2632693002: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… (Closed)
Patch Set: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
index 7d81050bb240ed61355e6480179b97e8ef5a41bb..a5d6b61e5f2b407b2f5d170bb97037f77a8cb956 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java
@@ -11,6 +11,7 @@ import android.content.Context;
import android.content.Intent;
import android.content.IntentFilter;
import android.content.pm.PackageInfo;
+import android.content.pm.PackageManager;
import android.graphics.Bitmap;
import android.support.test.filters.MediumTest;
import android.support.test.filters.SmallTest;
@@ -119,16 +120,15 @@ public class AppBannerManagerTest extends ChromeTabbedActivityTestBase {
public boolean isInstalled = false;
@Override
- public List<PackageInfo> getInstalledPackages(int flags) {
- List<PackageInfo> packages = new ArrayList<PackageInfo>();
-
+ public PackageInfo getPackageInfo(String packageName, int flags)
+ throws NameNotFoundException {
if (isInstalled) {
PackageInfo info = new PackageInfo();
info.packageName = NATIVE_APP_PACKAGE;
- packages.add(info);
+ return info;
+ } else {
+ throw new PackageManager.NameNotFoundException();
}
-
- return packages;
}
}

Powered by Google App Engine
This is Rietveld 408576698