Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java

Issue 2632693002: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… (Closed)
Patch Set: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
index 1df0607eee1b9c8459c92831eb1da8815a173cf2..4d207506746c18eb6081d5d321d34e950fb1e06b 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/banners/InstallerDelegateTest.java
@@ -14,9 +14,6 @@ import org.chromium.base.test.util.RetryOnFailure;
import org.chromium.content.browser.test.util.Criteria;
import org.chromium.content.browser.test.util.CriteriaHelper;
-import java.util.ArrayList;
-import java.util.List;
-
/**
* Tests the InstallerDelegate to make sure that it functions correctly and responds to changes
* in the PackageManager.
@@ -32,16 +29,14 @@ public class InstallerDelegateTest extends InstrumentationTestCase
public boolean isInstalled = false;
@Override
- public List<PackageInfo> getInstalledPackages(int flags) {
- List<PackageInfo> packages = new ArrayList<PackageInfo>();
-
- if (isInstalled) {
- PackageInfo info = new PackageInfo();
- info.packageName = MOCK_PACKAGE_NAME;
- packages.add(info);
+ public PackageInfo getPackageInfo(String packageName, int flags)
+ throws NameNotFoundException {
+ if (!isInstalled) {
+ throw new NameNotFoundException();
}
-
- return packages;
+ PackageInfo packageInfo = new PackageInfo();
+ packageInfo.packageName = MOCK_PACKAGE_NAME;
+ return packageInfo;
}
}
« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698