Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9139)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java

Issue 2632693002: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… (Closed)
Patch Set: The method WebappRegistry#isWebApkInstalled now reuses InstallerDelegate#isInstalled so as not to r… Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
index 9ee9075312b3efe99ab0b31b6abc1f194e7ce46e..1997ce97f279cb9b1ced3daafedd907400a81a4b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappRegistry.java
@@ -7,12 +7,12 @@ package org.chromium.chrome.browser.webapps;
import android.content.Context;
import android.content.SharedPreferences;
import android.content.pm.PackageManager;
-import android.content.pm.PackageManager.NameNotFoundException;
import android.os.AsyncTask;
import org.chromium.base.ContextUtils;
import org.chromium.base.VisibleForTesting;
import org.chromium.base.annotations.CalledByNative;
+import org.chromium.chrome.browser.banners.InstallerDelegate;
import org.chromium.chrome.browser.browsing_data.UrlFilter;
import org.chromium.chrome.browser.browsing_data.UrlFilterBridge;
@@ -257,13 +257,8 @@ public class WebappRegistry {
* Returns true if the given WebAPK is installed.
*/
private boolean isWebApkInstalled(String webApkPackage) {
- try {
- ContextUtils.getApplicationContext().getPackageManager().getPackageInfo(
- webApkPackage, PackageManager.GET_ACTIVITIES);
- } catch (NameNotFoundException e) {
- return false;
- }
- return true;
+ PackageManager packageManager = ContextUtils.getApplicationContext().getPackageManager();
+ return InstallerDelegate.isInstalled(packageManager, webApkPackage);
}
private static SharedPreferences openSharedPreferences() {

Powered by Google App Engine
This is Rietveld 408576698